Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #1247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Sep 2, 2024

Note: As per openedx/public-engineering#280 this can merge this after Sumac is cut.

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 2, 2024
@BilalQamar95 BilalQamar95 requested a review from a team as a code owner September 2, 2024 10:59
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (735d978) to head (a21fff7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1247   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files        1008     1008           
  Lines       18514    18514           
  Branches     3948     3958   +10     
=======================================
  Hits        17074    17074           
+ Misses       1373     1371    -2     
- Partials       67       69    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald
Copy link
Contributor

@BilalQamar95 Is this ready to merge, or are we waiting for something? And do you know why it's still showing "tests (18) Expected — Waiting for status to be reported" on the CI report here on GitHub?

@BilalQamar95
Copy link
Contributor Author

@BilalQamar95 Is this ready to merge, or are we waiting for something?

It was recently brought to my attention that there was openedx/public-engineering#280. After the Sumac cut, PRs removing Node 18 from the CI matrix can be merged.

And do you know why it's still showing "tests (18) Expected — Waiting for status to be reported" on the CI report here on GitHub?

It is due to test that runs on Node 18. tests (18) is a required check in the CI which needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants