-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved streamlit & console dashboards #466
Open
jmbowman
wants to merge
1
commit into
master
Choose a base branch
from
jmbowman/update_dashboards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,14 +23,30 @@ tables: | |
sql: SELECT repo_name, ownership_squad FROM dashboard_main WHERE exists__travis_yml = 1 | ||
description: We no longer use this service, the .travis.yml file can be safely deleted. If the repo was recently added (perhaps a fork) and actually uses Travis CI, please switch it to use GitHub Actions instead; Travis CI is poorly maintained and has had multiple security incidents leaking private credentials. | ||
|
||
- title: Not Checking for GitHub Action Version Updates | ||
sql: SELECT repo_name, ownership_squad FROM dashboard_main WHERE dependabot_has_ecosystem_github_actions = 0 | ||
description: Dependabot should be configured to auto-generate pull requests to upgrade the GitHub Actions in use so security patches can be applied promptly. | ||
|
||
- title: Still Use nose | ||
sql: SELECT repo_name, ownership_squad FROM dashboard_main WHERE requires_nose = 1 | ||
description: This test runner was abandoned several years ago, it should be replaced with pytest. | ||
|
||
- title: Still Using Dependabot to Create JavaScript Dependency Upgrade PRs | ||
sql: SELECT repo_name, ownership_squad FROM dashboard_main WHERE dependabot_has_ecosystem_npm = 1 | ||
description: Renovate is better suited to fulfill this need, and should be configured if that has not already been done. If Renovate is already in use, then the extra PRs from Dependabot are redundant and should be turned off. | ||
|
||
- title: Still Using Dependabot to Create Python Dependency Upgrade PRs | ||
sql: SELECT repo_name, ownership_squad FROM dashboard_main WHERE dependabot_has_ecosystem_pip = 1 | ||
description: The upgrade-python-requirements shared GitHub Actions workflow is better suited to fulfill this need, and should be configured if that has not already been done. If that is already in use, then the extra PRs from Dependabot are redundant and should be turned off. | ||
|
||
- title: Missing Python 3.8 Classifier | ||
sql: SELECT repo_name, ownership_squad FROM dashboard_main WHERE setup_py_pypi_name IS NOT NULL AND setup_py_pypi_name != '' AND setup_py_py38_classifiers = 0 | ||
description: All our packages should work with Python 3.8, and setup.py should declare this explicitly when true to inform users and aid in future upgrades. | ||
|
||
- title: Still Have Some Dependencies Not Tested With Django 3.2 | ||
sql: SELECT repo_name, ownership_squad, django_packages_total_count - django_packages_upgraded_count FROM dashboard_main WHERE django_packages_total_count > django_packages_upgraded_count | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great to have a check listing just the packages that don't seem to support Django 3.2, right now it would take some fancy post-processing to create that for the dashboard. Also, we should update this for 4.2. I'll ticket this after the holidays if it hasn't been resolved by then. |
||
description: The repository still seems to use some Python package versions which depend on Django but don't officially support Django 3.2 yet. They may in fact be working ok, but this is often a sign of poor maintenance and may cause problems with future upgrades. Work should be scheduled to either upgrade to newer releases, fix the upstream packages, or pursue removal of these dependencies as per https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies . | ||
|
||
# Use shorter and/or more readable column titles for these check names | ||
aliases: | ||
dependabot_alerts_critical_severity: Critical | ||
|
@@ -40,5 +56,6 @@ aliases: | |
dependabot_alerts_total_count: Total | ||
dependabot_alerts_incomplete_results: Incomplete? | ||
dependencies_github_list: List of packages | ||
"django_packages_total_count - django_packages_upgraded_count": Problematic dependency count | ||
repo_name: Repository | ||
ownership_squad: Squad |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This takes about 9 seconds on my laptop, so arguably a good alternative to downloading the database artifact. I want to write up a doc comparing the different download/generation options after the holiday break.