fix: Handle empty course_overviews in get_courses_order_by function #35912
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue in the
get_courses_order_by
function where an emptycourse_overviews
queryset caused an error. Previously, the function attempted to callorder_by()
on an empty or invalid queryset, leading to unexpected crashes. This change ensures that the function explicitly checks ifcourse_overviews
is empty and returns an empty list in such cases.Changes Made
Supporting information
This fixes the following traceback error:
The error occurred during course filtering and sorting operations in the CMS, where an invalid or empty course_overviews queryset caused the failure.
Testing instructions
Deadline
None
Other information