feat: added waffle flag for new notification view #35569
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais-ansari
requested changes
Oct 1, 2024
ayesha-waris
force-pushed
the
Ayesha/INF-1603
branch
2 times, most recently
from
9202028
to
f868a70
Compare
ayesha-waris
force-pushed
the
Ayesha/INF-1603
branch
from
f868a70
to
e9c813f
Compare
ayesha-waris
requested review from
awais-ansari,
AhtishamShahid and
muhammadadeeltajamul
| @@ -47,6 +47,10 @@ def get_show_notifications_tray(user): | |||
| return show_notifications_tray | |||
|
|
|||
|
|
|||
| def get_is_new_notification_view_enabled(): | |||
| return ENABLE_NEW_NOTIFICATION_VIEW.is_enabled() | |||
There was a problem hiding this comment.
Flag is implemented as course waffle fiag. Do we need course waffle flag type? if yes why was course_id not passed here?
There was a problem hiding this comment.
We need this flag to be enabled for everyone, if course_id is not provided the is_enabled method checks for permission (everyone, admin etc) and enables it accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1603
The ticket require new notifications view to be used by flag
notifications.enable_new_notification_view