-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create Course Limited Staff role [BB-7503] #32570
feat: create Course Limited Staff role [BB-7503] #32570
Conversation
Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
8667510
to
db3071a
Compare
db3071a
to
9365ce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x29a, I see you're reusing the commit from my PoC. Don't forget to add yourself as an author!
@mphilbrick211, are we going to need the product review for this? |
Checking with @jmakowski1123 on this. Thanks, @Agrendalath! |
bc5d270
to
252c88e
Compare
This is an experimental approach to introduce a role which has all Course Staff permissions, except for the Studio access. Co-authored-by: 0x29a <[email protected]>
252c88e
to
3ccfe7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: tested that the "Limited Staff" role provides access to the Instructor Dashboard, but not to the Studio.
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
@mphilbrick211, @jmakowski1123, a friendly reminder about this PR. This is ready to be merged from our end. |
approved |
@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Course Staff
, but no Studio access.This should be considered as a temporary workaround. Ideally, we should wait for “Fine grained RBAC” to be implemented (see this roadmap item) and build new roles using the refactored systems. See this document as well for additional context.
Testing instructions
open-craft:0x29a/bb7503/disable-instructor-access-to-studio
.[email protected]
and[email protected]
.[email protected]
toStaff
course team role using the Instructor Dashboard.[email protected]
toLimited Staff
course team role using the Instructor Dashboard.[email protected]
, ensure that you can access Studio.[email protected]
, ensure that you have the same permissions as[email protected]
(like accessing the Instructor Dashboard, etc), but don't have access to Studio.private-ref