Ansible Configuration to Dockerfile #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 9, 2022
aht007
reviewed
Dec 13, 2022
aht007
reviewed
Dec 13, 2022
aht007
reviewed
Dec 14, 2022
aht007
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Apart from the review suggestions that I have added, rest of the PR looks good code wise. I will have to test it locally on devstack before I give final approval. Also a thing that popped into my mind while reviewing is that, this service is deployed to production using Dockerfile so we should keep that in mind and also get it reviewed by Owning team and SRE.
iamsobanjaved
force-pushed
the
feature/ansible-to-docker
branch
2 times, most recently
from
8990b0e to
50f425f
Compare
iamsobanjaved
force-pushed
the
feature/ansible-to-docker
branch
from
50f425f to
36429d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: openedx-unsupported/edx-analytics-dashboard#1328
This PR is part of effort aimed at removing Ansible based configurations and replacing them with
Dockerfile. Currently Devstack Docker images are built usingAnsible based configurationsin theconfigurationsrepository. Through this effort we will make sure that the Repo has its ownDockerfilewhich has all the necessary configurations to setup small production and dev environments.Steps to run this Image with Devstack:
devi.e.docker build -t image-name-of-choice --target dev .docker composefile ofdevstackand replace the existingedx_notes_apiimage with the one that you built without changing any other configurations there.make dev.up.edx_notes_apiin the terminal while in the devstack directory.edx_notes_apiservices.