fix: move data dog config behind flag #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
requested review from
saadyousafarbi,
ayesha-waris and
muhammadadeeltajamul
ayesha-waris
approved these changes
Jun 10, 2024
blarghmatey
approved these changes
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 58 58
Lines 4624 4624
=======================================
Hits 4448 4448
Misses 176 176 ☔ View full report in Codecov by Sentry. |
asadazam93
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move data dog configurations behind a new flag To make sure it does not cause any issues with deployments without data dog setup.
Ticket
https://2u-internal.atlassian.net/browse/INF-1420