This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
build: use native Dockerfile for devstack #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsobanjaved
force-pushed
the
iamsobanjaved/ansible-dockerfile
branch
from
467f8de to
1cff475
Compare
iamsobanjaved
force-pushed
the
iamsobanjaved/ansible-dockerfile
branch
from
1cff475 to
1bad472
Compare
iamsobanjaved
changed the title
aht007
reviewed
Feb 7, 2023
aht007
reviewed
Feb 7, 2023
aht007
reviewed
Feb 7, 2023
aht007
reviewed
Feb 7, 2023
iamsobanjaved
force-pushed
the
iamsobanjaved/ansible-dockerfile
branch
from
1bad472 to
ca8cc71
Compare
As we are moving away from ansibles so we are going to use native Dockerfile for the registrar image to use in devstack.
iamsobanjaved
force-pushed
the
iamsobanjaved/ansible-dockerfile
branch
from
ca8cc71 to
47b29f8
Compare
schenedx
reviewed
Mar 1, 2023
| repository: edxops/registrar-dev | ||
| tags: ${{ steps.get-tag-name.outputs.result }},${{ github.sha }} | ||
|
|
||
| # - name: Build and push prod Docker image |
There was a problem hiding this comment.
Why comment out, and not delete? Is the point here to no longer push the image to edxops/registrar? Then why leave the commented out section here in the code?
There was a problem hiding this comment.
The image currently created at openedx/registrar is being used in the prod deployment, so we will stop pushing to that and in the meantime, we will merge this and test on devstack. If everything goes fine then we will enable that prod-related image.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: openedx-unsupported/devstack#946
This PR is part of effort aimed at removing Ansible based configurations and replacing them with Dockerfile. Currently Devstack Docker images are built using Ansible based configurations in the configurations repository. Through this effort we will make sure that the Repo has its own Dockerfile which has all the necessary configurations to setup small production and dev environments.
Steps to run this Image with Devstack:
devi.e.docker build -t image-name-of-choice --target dev .docker composefile ofdevstackand replace the existingregistrarimage with the one that you built without changing any other configurations there.make dev.up.registrarin the terminal while in the devstack directory.Related PRs: