This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
fix: use Form.Control to stop "Input" not defined error #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-smith-tcril
force-pushed
the
fix-input-not-defined
branch
from
7ed2e00 to
912671c
Compare
| @@ -362,7 +362,7 @@ const LibraryAuthoringPageHeaderBase = ({ intl, library, ...props }) => { | |||
| defaultValue={library.title} | |||
| onBlur={handleSaveTitle} | |||
| onKeyDown={event => { | |||
| if (event.key === 'Enter') { handleSaveTitle(event) } | |||
| if (event.key === 'Enter') { handleSaveTitle(event); } | |||
There was a problem hiding this comment.
added this to get past a linter error
|
+1! Thanks for this, @brian-smith-tcril! |
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rebasing #74, I ran into an issue with the library title edit functionality (I was getting an "Input" not defined error)
I decided to test on latest without my changes, and found the issue exists there too. I'm assuming this happened because #61 had not been tested again since #53 was merged
I've tested this replacement and all seems to work as expected.