-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: use links to navigate to library detail #437
refactor: use links to navigate to library detail #437
Conversation
Thanks for the pull request, @imasdekar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Makes the library card in the library list page, which navigate to a different page on click, to appear as links i.e. making the navigation address visible on hover. closes openedx-unsupported#414 - Signed-off by: Ishan Masdekar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 53.14% 53.07% -0.07%
==========================================
Files 80 80
Lines 2021 2018 -3
Branches 368 362 -6
==========================================
- Hits 1074 1071 -3
Misses 914 914
Partials 33 33 ☔ View full report in Codecov by Sentry. |
@imasdekar Thank you for this contribution! It looks like the changes are fixing a known issue (#414), so I'm assuming that we won't need to send them through product review. And we have a green build, so I'm marking this PR as ready for review. CC @connorhaugh as reporter of #414 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imasdekar Thanks for the contribution! I tested this locally and it works as expected.
👍
- I tested this: (locally using tutor nightly, the library items in the list are converted to accessible links)
- I read through the code
- I checked for accessibility issues
-
Includes documentation
@imasdekar @navinkarkera Marking this PR as ready for merge. |
@imasdekar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Makes the library card in the library list page, which navigate to a different page on click, to appear as links i.e. making the navigation address visible on hover.
closes #414