Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

refactor: use links to navigate to library detail #437

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

imasdekar
Copy link
Contributor

Makes the library card in the library list page, which navigate to a different page on click, to appear as links i.e. making the navigation address visible on hover.

closes #414

@openedx-webhooks
Copy link

Thanks for the pull request, @imasdekar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Makes the library card in the library list page, which navigate to a
different page on click, to appear as links i.e. making the navigation
address visible on hover.

closes openedx-unsupported#414

- Signed-off by: Ishan Masdekar <[email protected]>
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.07%. Comparing base (7303f79) to head (77ce1be).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   53.14%   53.07%   -0.07%     
==========================================
  Files          80       80              
  Lines        2021     2018       -3     
  Branches      368      362       -6     
==========================================
- Hits         1074     1071       -3     
  Misses        914      914              
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Jun 6, 2024

@imasdekar Thank you for this contribution!

It looks like the changes are fixing a known issue (#414), so I'm assuming that we won't need to send them through product review.

And we have a green build, so I'm marking this PR as ready for review.

CC @connorhaugh as reporter of #414

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 6, 2024
@itsjeyd itsjeyd requested a review from navinkarkera June 6, 2024 08:33
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imasdekar Thanks for the contribution! I tested this locally and it works as expected.

👍

  • I tested this: (locally using tutor nightly, the library items in the list are converted to accessible links)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 13, 2024
@itsjeyd
Copy link

itsjeyd commented Jun 13, 2024

@imasdekar @navinkarkera Marking this PR as ready for merge.

@navinkarkera navinkarkera merged commit 9199962 into openedx-unsupported:master Jun 17, 2024
7 checks passed
@openedx-webhooks
Copy link

@imasdekar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library Authoring UAT Feedback: Links must appear in the browser's status bar.
4 participants