Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Library Authoring UAT Feedback: Links must appear in the browser's status bar. #414

Closed
connorhaugh opened this issue Mar 5, 2024 · 1 comment · Fixed by #437
Closed

Library Authoring UAT Feedback: Links must appear in the browser's status bar. #414

connorhaugh opened this issue Mar 5, 2024 · 1 comment · Fixed by #437
Labels
bug Report of or fix for something that isn't working as intended

Comments

@connorhaugh
Copy link
Contributor

Hovering over many links (e.g. in the "Libraries" list) do not show the URL that they link to in the browser's status bar. This is an a11y issue - they aren't "real" links; but they should be as they go to a different page.
@connorhaugh connorhaugh added the bug Report of or fix for something that isn't working as intended label Mar 5, 2024
@arbrandes arbrandes moved this to Backlog in Frontend Working Group Mar 6, 2024
imasdekar added a commit to imasdekar/frontend-app-library-authoring that referenced this issue May 31, 2024
@imasdekar
refactor: makes the clickable text appear as links
03d34e0 
Makes the clickable texts which navigate to a different page to appear
as links i.e. making the navigation address visible on hover.

closes openedx-unsupported#414

- Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/frontend-app-library-authoring that referenced this issue May 31, 2024
@imasdekar
refactor: use links to navigate to library detail
006b79c 
Makes the library card in the library list page, which navigate to a
different page on click, to appear as links i.e. making the navigation
address visible on hover.

closes openedx-unsupported#414

- Signed-off by: Ishan Masdekar <[email protected]>
@imasdekar imasdekar mentioned this issue May 31, 2024
Merged
imasdekar added a commit to imasdekar/frontend-app-library-authoring that referenced this issue May 31, 2024
@imasdekar
refactor: use links to navigate to library detail
e33ff83 
Makes the library card in the library list page, which navigate to a
different page on click, to appear as links i.e. making the navigation
address visible on hover.

closes openedx-unsupported#414

- Signed-off by: Ishan Masdekar <[email protected]>
@imasdekar
Copy link
Contributor

@connorhaugh I have added a PR #437 for this issue

imasdekar added a commit to imasdekar/frontend-app-library-authoring that referenced this issue May 31, 2024
@imasdekar
refactor: use links to navigate to library detail
77ce1be 
Makes the library card in the library list page, which navigate to a
different page on click, to appear as links i.e. making the navigation
address visible on hover.

closes openedx-unsupported#414

- Signed-off by: Ishan Masdekar <[email protected]>
navinkarkera pushed a commit that referenced this issue Jun 17, 2024
@imasdekar @navinkarkera
refactor: use links to navigate to library detail
9199962 
Makes the library card in the library list page, which navigate to a
different page on click, to appear as links i.e. making the navigation
address visible on hover.

closes #414

- Signed-off by: Ishan Masdekar <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Closed in Frontend Working Group Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use links to navigate to library detail imasdekar/frontend-app-library-authoring
2 participants
@imasdekar @connorhaugh