This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
feat: Add dev.wait-for.% Make target; use in provisioning tests
#1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This target waits for a list of services to come up. While this is primarily intended as a developer feature, it should also fix some intermittent provisioning test failures that we think are race conditions (where dev.check is called too soon after dev.up). Also, increase check.sh log output limit to match dev.logs.
robrap
approved these changes
Oct 6, 2023
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
) This target waits for a list of services to come up. While this is primarily intended as a developer feature, it should also fix some intermittent provisioning test failures that we think are race conditions (where dev.check is called too soon after dev.up). Also, increase check.sh log output limit to match dev.logs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target waits for a list of services to come up. While this is primarily intended as a developer feature, it should also fix some intermittent provisioning test failures that we think are race conditions (where dev.check is called too soon after dev.up).
Also, increase check.sh log output limit to match dev.logs.
I've completed each of the following or determined they are not applicable: