fix incorrect docker secret handling #434 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Jerman <[email protected]>
github-actions
bot
requested review from
mittachaitu,
shubham14bajpai,
kmova and
prateekpandey14
prateekpandey14
suggested changes
Nov 3, 2023
There was a problem hiding this comment.
@sjerman you have to bump the chart version in Charts.yaml file.
|
Increased helm chart version from 3.5.0 -> 3.5.1 |
|
Looks like I need to signoff a couple of commits... Will do now. |
added 2 commits
November 3, 2023 08:26
Signed-off-by: Steve Jerman <[email protected]>
Signed-off-by: Steve Jerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues in the Helm chart. See #434