Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixing option #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add mixing option #201

wants to merge 1 commit into from

Conversation

bartvanwesten
Copy link
Collaborator

Before, after hydrodynamic mixing, the bed composition of the mixed layers was reset to the average of those layers.

On shorter term scale, this approach seems to work, but after longer simulation periods, the approach appears to result in an underestimation of fine particles emerging in the top layer. If armouring occurs for a long period, the average bed composition of all layers starts to become more coarse. After several years, during mixing no small particles were emerging to the top layer anymore.

To solve this, an optional mixing method could be implemented that does not reset the mixed bed to the current average of the layers, but to the original bed composition.

method_mixing = layer_average (default)

OR

method_mixing = reset_initial (new)

Before, after hydrodynamic mixing, the bed composition of the mixed layers was reset to the average of those layers.

On shorter term scale, this approach seems to work, but after longer simulation periods, the approach appears to result in an underestimation of fine particles emerging in the top layer. If armouring occurs for a long period, the average bed composition of all layers starts to become more coarse. After several years, during mixing no small particles were emerging to the top layer anymore.

To solve this, an optional mixing method could be implemented that does not reset the mixed bed to the current average of the layers, but to the original bed composition.

method_mixing = layer_average (default)

OR

method_mixing = reset_initial (new)
@bartvanwesten bartvanwesten requested a review from Sierd July 24, 2024 21:16
@Sierd
Copy link
Collaborator

Sierd commented Jul 24, 2024

@christavanijzendoorn and @bartvanwesten
I am not sure if we need that additional 'bedcomp_mixing_file'. Isn't the 'bedcomp_file' enough?

@christavanijzendoorn
Copy link
Collaborator

I agree with Sierd that there's no extra bedcomp_mixing_file needed. On line 109 of bed.py the bedcomp file is read and immediately converted into the mass parameter. This means the bedcomp file will still contain the initial bed composition and can be used in Bart's code to reset the bed composition. I think that'd save some lines of code and loading two bedcomp files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants