WIP: feature(pu): add Go env and AlphaZero league training #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
puyuan1996
commented
Jul 21, 2023
puyuan1996
commented
- add go_env, related unittest
- add go mcts bot and alphazero/muzero config
- add league version of alphazero
- add ctree version of alphazero
…r for tictactoe and gomoku
…option, fix norm_type in az prediction net, fix temperature in az_league
…lish league config
puyuan1996
added
enhancement
| if (action == -1) { | ||
| break; | ||
| } | ||
| simulate_env.attr("step")(action); |
There was a problem hiding this comment.
simulate_env 执行step后的board可以打印出来检查是否正确
|
|
||
| while (!node->is_leaf()) { | ||
| int action; | ||
| std::tie(action, node) = _select_child(node, simulate_env); |
There was a problem hiding this comment.
打印legal action查看每次select_child后是否输出正常。
| std::vector<std::pair<int, int>> action_visits; | ||
| // std::cout << "position11 " << std::endl; | ||
| for (int action = 0; action < simulate_env.attr("action_space").attr("n").cast<int>(); ++action) { | ||
| if (root->children.count(action)) { |
There was a problem hiding this comment.
为啥是count不是std::find？
| Node* parent; | ||
| float prior_p; | ||
| int visit_count; | ||
| float value_sum; |
|
|
||
| int action = -1; | ||
| Node* child = nullptr; | ||
| double best_score = -9999999; |
There was a problem hiding this comment.
double 是浮点数 初始化为浮点数而不是负整数
| // std::cout << "position8 " << std::endl; | ||
| _simulate(root, simulate_env_copy, policy_forward_fn); | ||
| // std::cout << "position9 " << std::endl; | ||
| simulate_env_copy = py::none(); |
|
|
||
| while (!node->is_leaf()) { | ||
| int action; | ||
| std::tie(action, node) = _select_child(node, simulate_env); |
There was a problem hiding this comment.
_select_child的返回值是指针，这儿为啥还需要tie
…tago_game_state, polish go_alphazero_league_config
PaParaZz1
changed the title
|
We have a new polished PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.