Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login on discuss #606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

at-github
Copy link
Contributor

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit d28d260
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/6748930fe64cf900081c4e06
😎 Deploy Preview https://deploy-preview-606--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@at-github
Copy link
Contributor Author

Comme mentionné dans le ticket, l'erreur vient du JSON.stringify de l'objet, qui semble avoir une référence circulaire. Je propose de ne transmettre que le fullPath

@at-github at-github marked this pull request as ready for review November 28, 2024 13:29
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit d28d260
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/6748930f8218850008f614d1
😎 Deploy Preview https://deploy-preview-606--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut certainement le changer là aussi

LocalStorageService.setItem('lastRoute', to)
(et vérifier qu'on garde bien la query string complète)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Discussions - bouton se connecter
2 participants