fix: authz patch injection feature precondition uses correct namespace value #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the authorization provider namespace is not specified in the DSCI the default is constructed to be `application-namespace-auth-provider`, e.g. `opendatahub-auth-provider`. With the opendatahub-io#1052 refactoring, the regression has been introduced where the value is directly read from the spec instead of being dynamically constructed based on the rule described above. This is manifested with the following error, as the feature mistakenly waits for pods across all namespaces (because of list option for namespace being `corev1.NamespaceAll == ""`). This obviously rarely is true, especially for large clusters. ```json Failed applying [enable-proxy-injection-in-authorino-deployment]: 1 error occurred: * client rate limiter Wait returned an error: context deadline exceeded ``` leading to failure of reconciling this feature. The fix is to read the namespace from `FeatureData` instead, where the defaulting logic is defined. Fixes https://issues.redhat.com/browse/RHOAIENG-10268
zdtsw
requested review from
VaishnaviHire
and removed request for
LaVLaS and
jackdelahunt
zdtsw
reviewed
Jul 23, 2024
Co-authored-by: Wen Zhou <[email protected]>
zdtsw
approved these changes
Jul 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
test with local build quay.io/wenzhou/opendatahub-operator-catalog:v2.7.23 |
openshift-merge-bot
bot
merged commit 7034768
into
opendatahub-io:incubation
8 checks passed
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…e value (opendatahub-io#1135) * fix: fixes authz patch injection feature precondition If the authorization provider namespace is not specified in the DSCI the default is constructed to be `application-namespace-auth-provider`, e.g. `opendatahub-auth-provider`. With the opendatahub-io#1052 refactoring, the regression has been introduced where the value is directly read from the spec instead of being dynamically constructed based on the rule described above. This is manifested with the following error, as the feature mistakenly waits for pods across all namespaces (because of list option for namespace being `corev1.NamespaceAll == ""`). This obviously rarely is true, especially for large clusters. ```json Failed applying [enable-proxy-injection-in-authorino-deployment]: 1 error occurred: * client rate limiter Wait returned an error: context deadline exceeded ``` leading to failure of reconciling this feature. The fix is to read the namespace from `FeatureData` instead, where the defaulting logic is defined. Fixes https://issues.redhat.com/browse/RHOAIENG-10268 * Update controllers/dscinitialization/servicemesh_setup.go Co-authored-by: Wen Zhou <[email protected]> --------- Co-authored-by: Wen Zhou <[email protected]> (cherry picked from commit 7034768)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…e value (opendatahub-io#1135) * fix: fixes authz patch injection feature precondition If the authorization provider namespace is not specified in the DSCI the default is constructed to be `application-namespace-auth-provider`, e.g. `opendatahub-auth-provider`. With the opendatahub-io#1052 refactoring, the regression has been introduced where the value is directly read from the spec instead of being dynamically constructed based on the rule described above. This is manifested with the following error, as the feature mistakenly waits for pods across all namespaces (because of list option for namespace being `corev1.NamespaceAll == ""`). This obviously rarely is true, especially for large clusters. ```json Failed applying [enable-proxy-injection-in-authorino-deployment]: 1 error occurred: * client rate limiter Wait returned an error: context deadline exceeded ``` leading to failure of reconciling this feature. The fix is to read the namespace from `FeatureData` instead, where the defaulting logic is defined. Fixes https://issues.redhat.com/browse/RHOAIENG-10268 * Update controllers/dscinitialization/servicemesh_setup.go Co-authored-by: Wen Zhou <[email protected]> --------- Co-authored-by: Wen Zhou <[email protected]> (cherry picked from commit 7034768)
MarianMacik
pushed a commit
to MarianMacik/opendatahub-operator
that referenced
this pull request
Jan 22, 2025
…flux/component-updates/odh-dashboard-v2-17 chore(deps): update odh-dashboard-v2-17 to 0ea1a6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the authorization provider namespace is not specified in the DSCI the default is constructed to be
application-namespace-auth-provider, e.g.opendatahub-auth-provider.With the #1052 refactoring, the regression has been introduced where the value is directly read from the spec instead of being dynamically constructed based on the rule described above.
This is manifested with the following error, as the feature mistakenly waits for pods across all namespaces (because of list option for namespace being
corev1.NamespaceAll == ""). This obviously rarely is true, especially for large clusters.leading to failure of reconciling this feature.
The fix is to read the namespace from
FeatureDatainstead, where the defaulting logic is defined.Fixes https://issues.redhat.com/browse/RHOAIENG-10268
How Has This Been Tested?
Screenshot or short clip
Merge criteria