Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model redeploying status #3513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emilys314
Copy link
Contributor

Closes https://issues.redhat.com/browse/RHOAIENG-3409

Description

Makes the status a spinner after editing a model, popover message says "Redeploying".

Basically the status functions will prioritize looking at the target state, since that is more indicative of what is going on.
I'm not 100% on what the correct message is to display. But the special return case could be removed and then it would default to the state of the target i.e. "Loading".

image

How Has This Been Tested?

  1. Deploy a model
  2. Edit the model and change something (most things will reload it)
  3. The status should change to loading (the polling may be slow to update it)

Test Impact

Jest unit tests could be added to the utils functions, but there aren't any so i didn't add any.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

@vconzola

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@emilys314
Copy link
Contributor Author

cc @alexcreasy @lucferbux

@vconzola
Copy link

@kaedward Would you please take a quick peek at this? I think it looks OK, but you might have a different suggestion for the popover message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants