handle workbench not enabled

[Gkrumbach07]

https://issues.redhat.com/browse/RHOAIENG-15252

Description

hides workbench related things when the area is not enabled

How Has This Been Tested?

disable workbenches and check that everything from jira is hidden

Test Impact

added tests to areas project list and project details

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gkrumbach07. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (5fccd14) to head (9d888c4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
+ Coverage   85.39%   85.41%   +0.01%     
==========================================
  Files        1352     1352              
  Lines       30947    30969      +22     
  Branches     8648     8660      +12     
==========================================
+ Hits        26428    26451      +23     
+ Misses       4519     4518       -1     

Files with missing lines	Coverage Δ
frontend/src/components/OdhAppCard.tsx	61.40% <100.00%> (+1.40%)	⬆️
...c/pages/projects/screens/detail/ProjectDetails.tsx	96.77% <100.00%> (+0.34%)	⬆️
...detail/overview/trainModels/TrainModelsSection.tsx	100.00% <100.00%> (ø)
...s/projects/screens/detail/storage/StorageTable.tsx	100.00% <100.00%> (ø)
...rojects/screens/detail/storage/StorageTableRow.tsx	97.36% <100.00%> (+0.22%)	⬆️
...ages/projects/screens/projects/ProjectListView.tsx	76.00% <100.00%> (+2.08%)	⬆️
...ages/projects/screens/projects/ProjectTableRow.tsx	95.12% <100.00%> (+0.38%)	⬆️

... and 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fccd14...9d888c4. Read the comment docs.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[DaoDaoNoCode]

I got some questions:

1. How are we going to deal with the Existing connected workbenches and Connected workbench fields in this situation?

2. Should we block fetch to all the notebooks if the workbench flag is disabled?
3. This button on Global project page should be disabled or hidden definitely

4. I can still access the notebook controller via URL (not through the UI), should we disable the route as well?

[Gkrumbach07]

1. i say we hide them
2. block all fetch - no, lets just hide where we would try to display it (i know its probably still fetching in the background but i think that is ok)
3. i will disable it
4. url no, we dont do that in the dashboard

[dpanshug]

Can you add the feature flag here

odh-dashboard/frontend/src/concepts/areas/const.ts

Line 93 in f0b961c

// featureFlags: [], // TODO: We want to disable, no flag exists today

Also here so we can disable the feature flag from disableFeatureFlags banner.

odh-dashboard/frontend/src/concepts/areas/const.ts

Line 4 in f0b961c

export const allFeatureFlags: string[] = Object.keys({

Edit: I see now, we're not adding a feature flag, taking it back.