Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update 'Resource name' fields to meet UX guidelines: Cluster storage #3483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeff-phillips-18
Copy link
Contributor

WIP

Depends on

Closes RHOAIENG-14746

Description

Updates create/edit cluster storage modals to use K8sNameDescriptionField component in order to meet current UX guidelines.

Screen shots

Create cluster storage

image

Create cluster storage - edit resource name

image

Edit cluster storage

image

How Has This Been Tested?

  • Navigate to a project and go to the Cluster storage tab

    • Select Add cluster storage
    • Enter a name
    • Verify the Add storage button is enabled
    • View the resource name via the Edit resource name link.
    • Change the resource name to something invalid (ie. contains a space)
    • Verify the Add storage button is disabled
    • Change the resource name to something valid
    • Enter a description
    • Verify the Add storage button is enabled
    • Save the storage.
    • Verify the cluster storage is created with the correct Display name and Resource Name and Description.
  • Navigate to a project and go to the Cluster storage tab

    • Select a kebab for an existing cluster storage item
    • Select Edit storage
    • Verify the name, resource name, and description are shown correctly
    • Verify the resource name is not editable
  • Navigate to a project and go to the Workbenches tab

    • Select Create workbench
    • Enter a name
    • Select an Image
    • Verify the Create workbench button is enabled
    • Click the Create storage button
      • Enter a name
      • Enter a valid mount path
      • Verify the Create button is enabled
      • View the resource name via the Edit resource name link.
      • Change the resource name to something invalid (ie. contains a space)
      • Verify the Create button is disabled
      • Change the resource name to something valid
      • Enter a description
      • Verify the Create button is enabled
      • Save the storage.
    • In the Cluster storage list, select the kebab next to the new storage to be created
      • Verify the cluster storage is created with the correct Display name and Resource Name and Description.

Test Impact

Updated unit tests for new fields

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @simrandhaliw

Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 94.39252% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (3ba248d) to head (6fdbc3e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...screens/projects/kServeModal/ManageKServeModal.tsx 93.02% 3 Missing ⚠️
...erenceServiceModal/ManageInferenceServiceModal.tsx 92.30% 2 Missing ⚠️
...creens/spawner/storage/CreateNewStorageSection.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3483      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files        1355     1354       -1     
  Lines       31074    31074              
  Branches     8663     8665       +2     
==========================================
+ Hits        26489    26494       +5     
+ Misses       4585     4580       -5     
Files with missing lines Coverage Δ
...8sNameDescriptionField/K8sNameDescriptionField.tsx 100.00% <100.00%> (ø)
...ojects/screens/detail/storage/BaseStorageModal.tsx 80.95% <100.00%> (-1.66%) ⬇️
...rc/pages/projects/screens/spawner/storage/utils.ts 69.23% <100.00%> (+1.23%) ⬆️
frontend/src/pages/projects/types.ts 100.00% <ø> (ø)
frontend/src/utilities/useGenericObjectState.ts 100.00% <100.00%> (ø)
...creens/spawner/storage/CreateNewStorageSection.tsx 96.29% <90.90%> (-3.71%) ⬇️
...erenceServiceModal/ManageInferenceServiceModal.tsx 93.75% <92.30%> (-0.08%) ⬇️
...screens/projects/kServeModal/ManageKServeModal.tsx 94.03% <93.02%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa74ed9...6fdbc3e. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant