Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: upstream kubeflow main to midstream odh main #7

Merged
merged 7 commits into from
Feb 22, 2024
Merged

sync: upstream kubeflow main to midstream odh main #7

merged 7 commits into from
Feb 22, 2024

Conversation

tarilabs
Copy link
Member

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • [n/a] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [n/a] The developer has manually tested the changes and verified that the changes work

lampajr and others added 5 commits February 20, 2024 11:48
@lampajr
kubeflow: remove operator test in pr check (kubeflow#16)
7bcdc49 
Signed-off-by: Andrea Lamparelli <[email protected]>
@tarilabs
kubeflow: disable codecov reporting GHA step (kubeflow#14)
314e7ed 
Signed-off-by: tarilabs <[email protected]>
@dependabot
build(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1 (kubef…
ef850cf 
…low#12)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.0 to 1.61.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.0...v1.61.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump github.com/go-chi/chi/v5 from 5.0.11 to 5.0.12 (kub…
6c29dcd 
…eflow#11)

Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.0.11 to 5.0.12.
- [Release notes](https://github.com/go-chi/chi/releases)
- [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md)
- [Commits](go-chi/chi@v5.0.11...v5.0.12)

---
updated-dependencies:
- dependency-name: github.com/go-chi/chi/v5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tarilabs
Merge branch 'main' into tarilabs-20240221-testSync2
4658d0b
@tarilabs tarilabs requested a review from lampajr February 21, 2024 11:11
@openshift-ci openshift-ci bot requested review from dhirajsb and isinyaaa February 21, 2024 11:11
lampajr
lampajr approved these changes Feb 21, 2024
View reviewed changes
Copy link

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarilabs !

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lampajr, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs tarilabs mentioned this pull request Feb 21, 2024
Closed
@tarilabs
Copy link
Member Author

received feedback in scrum-of-scrum this is a reasonable way of handling our cases.

@tarilabs tarilabs force-pushed the tarilabs-20240221-testSync2 branch from 6c6b58b to 7cf49f7 Compare February 21, 2024 16:00
@openshift-ci openshift-ci bot removed the lgtm label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

@tarilabs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-cfo 7cf49f7 link true /test e2e-odh-cfo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tarilabs
Copy link
Member Author

received feedback in scrum-of-scrum this is a reasonable way of handling our cases, also followed up on slack if we wanted to keep commit id hash this sounds the best flow; proceeding to merge-commit

@tarilabs tarilabs merged commit 70b6579 into opendatahub-io:main Feb 22, 2024
9 of 11 checks passed
@tarilabs tarilabs mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr approved these changes

@dhirajsb dhirajsb Awaiting requested review from dhirajsb

@isinyaaa isinyaaa Awaiting requested review from isinyaaa

Assignees

@lampajr lampajr

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @lampajr