[pull] main from kubeflow:main #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Signed-off-by: Matteo Mortari <[email protected]>
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 75.84% 78.65% +2.81%
==========================================
Files 19 14 -5
Lines 2215 745 -1470
Branches 101 101
==========================================
- Hits 1680 586 -1094
+ Misses 340 127 -213
+ Partials 195 32 -163 ☔ View full report in Codecov by Sentry. |
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.2 to 1.19.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.18.2...v1.19.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): py bump docker ^7.1.0, requests ^2.32.2 Signed-off-by: Matteo Mortari <[email protected]> * add Mac OSX specific instructions Signed-off-by: Matteo Mortari <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella Basso <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella Basso <[email protected]>
…116) * docs(py): document workaround using MR client with newer py versions Signed-off-by: Matteo Mortari <[email protected]> * reword paragraphs following review feedback Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]>
* core: rearrange fields to reduce struct size Signed-off-by: Isabella do Amaral <[email protected]> * ignore debug files Signed-off-by: Isabella do Amaral <[email protected]> * api: fix http status error conversion Signed-off-by: Isabella do Amaral <[email protected]> --------- Signed-off-by: Isabella do Amaral <[email protected]>
…/python (#122) Bumps [typing-extensions](https://github.com/python/typing_extensions) from 4.11.0 to 4.12.1. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.11.0...4.12.1) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#123) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.5.2 to 7.5.3. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.5.2...7.5.3) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…on (#124) Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 4.1.0 to 5.0.0. - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v4.1.0...v5.0.0) --- updated-dependencies: - dependency-name: pytest-cov dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: fetch MR endpoint In this PR: - New kubernetes client (integrations/k8s.go) - Fetch model registries handler (model_registry_handler.go) Signed-off-by: Eder Ignatowicz <[email protected]> * Small reminder on a TODO Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]>
tarilabs
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
- keep docs: fix typo in diagrams kubeflow/model-registry#119
- keep build(deps): bump github.com/spf13/viper from 1.18.2 to 1.19.0 kubeflow/model-registry#121
- keep chore(deps): py bump docker ^7.1.0, requests ^2.32.2 kubeflow/model-registry#115
- keep docs(py): document workaround using MR client with newer py versions kubeflow/model-registry#116
- keep Fix http error codes kubeflow/model-registry#125
- keep chore(gha): github action for BFF kubeflow/model-registry#127
- keep docs(py): document workaround using MR client with newer py versions kubeflow/model-registry#116
- keep build(deps): bump typing-extensions from 4.11.0 to 4.12.1 in /clients/python kubeflow/model-registry#122
- keep build(deps-dev): bump coverage from 7.5.2 to 7.5.3 in /clients/python kubeflow/model-registry#123
- keep build(deps-dev): bump pytest-cov from 4.1.0 to 5.0.0 in /clients/python kubeflow/model-registry#124
- keep feat: fetch MR endpoint kubeflow/model-registry#128
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b2d3397
into
opendatahub-io:main
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )