-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from kubeflow:main #46
Conversation
* py: fix type annotations to return concrete types Signed-off-by: Isabella Basso do Amaral <[email protected]> * py: fix missing type check on empty list results Signed-off-by: Isabella Basso do Amaral <[email protected]> --------- Signed-off-by: Isabella Basso do Amaral <[email protected]>
need to adapt property definition in OpenAPI to accomodate openapi-codegen result; according to contract (as also visible in swagger) the ModelVersion is to contain property: registeredModelId Signed-off-by: Matteo Mortari <[email protected]>
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 76.09% 76.39% +0.30%
==========================================
Files 19 19
Lines 2129 2135 +6
Branches 93 93
==========================================
+ Hits 1620 1631 +11
+ Misses 319 316 -3
+ Partials 190 188 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4e2a58c
into
opendatahub-io:main
This reverts commit 4e2a58c. Missing the correct label, the automated merge did not merge-commit but squash-commit. Reverting.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )