[pull] main from kubeflow:main #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
align diagram about testing architecture following #326 include FOSSA license scanning badge following #323 Signed-off-by: Matteo Mortari <[email protected]>
… multi-arch builds Fixes RHOAIENG-12078 (#322) * fix: remove .git from Dockerfile Signed-off-by: Dhiraj Bokde <[email protected]> * fix: remove git check for model-registry.yaml in Makefile fix gen/openapi-server make target to generate go-server if model-registry.yaml file is newer Signed-off-by: Dhiraj Bokde <[email protected]> * fix: commit updated type_asserts.go Signed-off-by: Dhiraj Bokde <[email protected]> * fix: sort assert functions in gen_type_asserts.sh before writing them to type_asserts.go Signed-off-by: Dhiraj Bokde <[email protected]> * feat: add 'image/buildx' target to create multi-platform docker images using docker buildx, split 'build' target into 'build/prepare' and 'build/compile' to optimize multi-platform builds Signed-off-by: Dhiraj Bokde <[email protected]> * feat: add docker env variables to enable multi-platform cross compilation, optimize build steps Signed-off-by: Dhiraj Bokde <[email protected]> * fix: add podman support for buildx Signed-off-by: Dhiraj Bokde <[email protected]> * fix: remove docker builder if it already exists Signed-off-by: Dhiraj Bokde <[email protected]> --------- Signed-off-by: Dhiraj Bokde <[email protected]>
* doc: skip method description until MLMD bug is fixed Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella do Amaral <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> * py: README: explicit MR connection options Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella do Amaral <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> * py: README: restore prints Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella do Amaral <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> * py: README: add missing import from utils Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella do Amaral <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> * py: README: get rid of legacy note Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella do Amaral <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> * Update clients/python/README.md Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Isabella Basso <[email protected]> * Update clients/python/README.md Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Isabella Basso <[email protected]> * Update clients/python/README.md Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Isabella Basso <[email protected]> * Update clients/python/README.md Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Isabella Basso <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> Signed-off-by: Isabella Basso <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
github-actions
bot
added
Area/MR Python client
Area/Go REST server
Area/Documentation
labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 78.23% 76.35% -1.88%
==========================================
Files 23 11 -12
Lines 2118 1476 -642
Branches 145 0 -145
==========================================
- Hits 1657 1127 -530
+ Misses 269 190 -79
+ Partials 192 159 -33 ☔ View full report in Codecov by Sentry. |
* update golangci-lint Signed-off-by: Isabella do Amaral <[email protected]> * ignore cypress artifacts Signed-off-by: Isabella do Amaral <[email protected]> * gen type asserts in python Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Isabella do Amaral <[email protected]> --------- Signed-off-by: Isabella do Amaral <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
tarilabs
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
- keep docs: update README kubeflow/model-registry#400
- keep fix: fix Makefile and Dockerfile for idempotent images and to support multi-arch builds Fixes RHOAIENG-12078 kubeflow/model-registry#322
- keep Py: update README kubeflow/model-registry#402
- keep Fix type assert generation on MacOS kubeflow/model-registry#403
labels are applied.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 03d83e6
into
opendatahub-io:main
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )