Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dockerfile NodeJS version for openapi-generator-cli #273

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

tarilabs
Copy link
Member

Resolves #271

Description

How Has This Been Tested?

testing locally and on GHA by raising this PR, expecting green GHA while invoking Docker builds.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0497cf4) 74.16% compared to head (bce364f) 74.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   74.16%   74.16%           
=======================================
  Files          17       17           
  Lines        2295     2295           
  Branches       73       73           
=======================================
  Hits         1702     1702           
  Misses        426      426           
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @tarilabs for the fix!!

As we discussed we might think about removing the re-generation phase from the Dockerfile. In this case we can completely remove the download of external tools like protoc and openapi-generator-cli

@tarilabs
Copy link
Member Author

tarilabs commented Jan 25, 2024

As we discussed we might think about removing the re-generation phase from the Dockerfile. In this case we can completely remove the download of external tools like protoc and openapi-generator-cli

I concur, but for the moment, this PR would fix our (broken) build [for the time being]. Do you agree to proceed with this anyway, and eventually this fix would be superseeded by that proposal?

@lampajr
Copy link
Contributor

lampajr commented Jan 25, 2024

I concur, but for the moment, this PR would fix our (broken) build [for the time being]. Do you agree to proceed with this anyway, and eventually this fix would be superseeded by that proposal?

Definitely agree with this ^^

@tarilabs tarilabs merged commit 225a2d7 into opendatahub-io:main Jan 25, 2024
8 checks passed
dhirajsb pushed a commit to dhirajsb/model-registry that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test container build is failing: error downloading openapi-generator-cli
3 participants