Add parentResourceID param for FindInferenceService

opendatahub-io · Feb 15, 2024 · b598085 · b598085
1 parent 90f7ddc
commit b598085
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/api/openapi/model-registry.yaml b/api/openapi/model-registry.yaml
@@ -482,6 +482,7 @@ paths:
     parameters:
       - $ref: "#/components/parameters/name"
       - $ref: "#/components/parameters/externalID"
+      - $ref: "#/components/parameters/parentResourceID"
   "/api/model_registry/v1alpha1/inference_services/{inferenceserviceId}":
     summary: Path used to manage a single InferenceService.
     description: >-

diff --git a/internal/server/openapi/api.go b/internal/server/openapi/api.go
@@ -71,7 +71,7 @@ type ModelRegistryServiceAPIServicer interface {
 	CreateRegisteredModel(context.Context, model.RegisteredModelCreate) (ImplResponse, error)
 	CreateRegisteredModelVersion(context.Context, string, model.ModelVersion) (ImplResponse, error)
 	CreateServingEnvironment(context.Context, model.ServingEnvironmentCreate) (ImplResponse, error)
-	FindInferenceService(context.Context, string, string) (ImplResponse, error)
+	FindInferenceService(context.Context, string, string, string) (ImplResponse, error)
 	FindModelArtifact(context.Context, string, string, string) (ImplResponse, error)
 	FindModelVersion(context.Context, string, string, string) (ImplResponse, error)
 	FindRegisteredModel(context.Context, string, string) (ImplResponse, error)

diff --git a/internal/server/openapi/api_model_registry_service.go b/internal/server/openapi/api_model_registry_service.go
@@ -482,7 +482,8 @@ func (c *ModelRegistryServiceAPIController) FindInferenceService(w http.Response
 	query := r.URL.Query()
 	nameParam := query.Get("name")
 	externalIDParam := query.Get("externalID")
-	result, err := c.service.FindInferenceService(r.Context(), nameParam, externalIDParam)
+	parentResourceIDParam := query.Get("parentResourceID")
+	result, err := c.service.FindInferenceService(r.Context(), nameParam, externalIDParam, parentResourceIDParam)
 	// If an error occurred, encode the error with the status code
 	if err != nil {
 		c.errorHandler(w, r, err, &result)

diff --git a/internal/server/openapi/api_model_registry_service_service.go b/internal/server/openapi/api_model_registry_service_service.go
@@ -165,8 +165,8 @@ func (s *ModelRegistryServiceAPIService) CreateServingEnvironment(ctx context.Co
 }
 
 // FindInferenceService - Get an InferenceServices that matches search parameters.
-func (s *ModelRegistryServiceAPIService) FindInferenceService(ctx context.Context, name string, externalID string) (ImplResponse, error) {
-	result, err := s.coreApi.GetInferenceServiceByParams(&name, nil, &externalID)
+func (s *ModelRegistryServiceAPIService) FindInferenceService(ctx context.Context, name string, externalID string, parentResourceID string) (ImplResponse, error) {
+	result, err := s.coreApi.GetInferenceServiceByParams(&name, &parentResourceID, &externalID)
 	if err != nil {
 		return Response(500, model.Error{Message: err.Error()}), nil
 	}

diff --git a/pkg/openapi/api_model_registry_service.go b/pkg/openapi/api_model_registry_service.go