[v0.11.1] Allow disabling creation of the HPA in raw deployment mode (#3086) #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor autoscaler functionality into an interface. Add no-op autoscaler so users disable creation of autoscaler resources. Add AutoscalerClassNone feature with test cases Signed-off-by: jooho <[email protected]> Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> * Rollback getHPAMetrics to set ScaleTarget,ScaleMetric Signed-off-by: jooho <[email protected]> Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> * Fix merge conflict Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> * Fix autoscaler api group Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> * Fix autoscaler merge Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> * Fix autoscaling tests Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> * Updated hpa disable test. Signed-off-by: Andrews Arokiam <[email protected]> * Replaced "AutoscalerClassNone" with "AutoscalerClassExternal" Signed-off-by: Andrews Arokiam <[email protected]> * Fixed autoscalerClass 'external' go test. Signed-off-by: Andrews Arokiam <[email protected]> --------- Signed-off-by: jooho <[email protected]> Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> Co-authored-by: Curtis Maddalozzo <[email protected]> Co-authored-by: jooho <[email protected]> Co-authored-by: Dan Sun <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
israel-hdez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of kserve#3086