Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync #159

Merged
merged 35 commits into from
Jan 4, 2024
Merged

Sync #159

merged 35 commits into from
Jan 4, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Jan 3, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Jooho and others added 30 commits December 8, 2023 14:22
* Add CA bundle configuration

Signed-off-by: Danilo Peixoto <[email protected]>

* Implement CA bundle volume mount

Signed-off-by: Danilo Peixoto <[email protected]>

* Update tests

Signed-off-by: Danilo Peixoto <[email protected]>

* Add default mount path

Signed-off-by: Danilo Peixoto <[email protected]>

* Update defaults

Signed-off-by: Danilo Peixoto <[email protected]>

* Update constants

Signed-off-by: Danilo Peixoto <[email protected]>

* Use constant

Signed-off-by: Danilo Peixoto <[email protected]>

* Implement tests

Signed-off-by: Danilo Peixoto <[email protected]>

* Rename volume

Signed-off-by: Danilo Peixoto <[email protected]>

* Fix name references

Signed-off-by: Danilo Peixoto <[email protected]>

* Update configmap

Signed-off-by: Danilo Peixoto <[email protected]>

* fix unit test for pr-3216

Signed-off-by: jooho <[email protected]>

* add a logic to mount cabundle secret to storage-initializer container

Signed-off-by: jooho <[email protected]>

* Correct failed conflict resolve of storage_initializer_injector.go

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in go.sum

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in openapi_generated.go

Signed-off-by: Christian Kadner <[email protected]>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <[email protected]>

* convert Secret to ConfigMap for cabundle

Signed-off-by: jooho <[email protected]>

* update some sources to solve reviews

Signed-off-by: jooho <[email protected]>

* Add 'cabundle_configmap' to 'storage-config' StorageSpec

Signed-off-by: jooho <[email protected]>

* fix new comments

Signed-off-by: jooho <[email protected]>

* update to fix review comments

Signed-off-by: jooho <[email protected]>

---------

Signed-off-by: Danilo Peixoto <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: jooho <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Jooho Lee <[email protected]>
Co-authored-by: Danilo Peixoto <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
Co-authored-by: Christian Kadner <[email protected]>
* Update Istio-Dex docs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add docs for auth using service account

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix kfserving name 

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
…rror in future (kserve#3272)

* Update ray serve version
Update tests to remove detached=false parameter

Signed-off-by: Andrews Arokiam <[email protected]>

* Pinned `async-timeout` as direct dependency for python 3.11

Signed-off-by: Andrews Arokiam <[email protected]>

---------

Signed-off-by: Andrews Arokiam <[email protected]>
* Fix qpext hangs during shutdown

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix e2e qpext image build

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Revert vcs info stamping

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
chore: Upgrade to XGBoost v2.0.2

Signed-off-by: Yuan Tang <[email protected]>
* fix: Check if HPA has the same scaleTargetRef

Signed-off-by: Yuan Tang <[email protected]>

* Update pkg/controller/v1beta1/inferenceservice/reconcilers/hpa/hpa_reconciler.go

Co-authored-by: Jooho Lee <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>

* chore: simplify semanticHPAEquals

Signed-off-by: Yuan Tang <[email protected]>

* chore: simplify

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
Co-authored-by: Jooho Lee <[email protected]>
kserve#3311)

* Updated quick_install script.

Signed-off-by: Andrews Arokiam <[email protected]>

* Use existing variables for checking versions

Signed-off-by: Andrews Arokiam <[email protected]>

* Fixed typo mistakes.

Signed-off-by: Andrews Arokiam <[email protected]>

---------

Signed-off-by: Andrews Arokiam <[email protected]>
* replace github.com/golang/protobuf

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* regenerate tf2openapi

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* remove use of github.com/gogo/protobuf pkg

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Add health check probe for controller manager

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* fmt

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* make manifests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Remove startup probe

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update helm chart

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Move ksvc dry run logic inside retry

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* remove retry on ig and isvc

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
… than the total model features on lightgbm (kserve#3313)

Fix inference request fails when sending with less number of features than the total model features

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Add a CI_USE_ISVC_HOST for testing with the ISVC hostname

This adds the possibility to run E2E tests using the hostname specified in the `status.url` field of the InferenceServices, rather than using the ClusterIP of the Istio Ingress gateway.

This behavior is enabled by, first, setting the `CI_USE_ISVC_HOST=1` environment variable and, then invoking pytest. Thus, the original behavior of using Istio IngressGateway ClusterIP is the default one.

Signed-off-by: Edgar Hernández <[email protected]>

* Add a CI_USE_ISVC_HOST for testing with the ISVC hostname

This adds the possibility to run E2E tests using the hostname specified in the `status.url` field of the InferenceServices, rather than using the ClusterIP of the Istio Ingress gateway.

This behavior is enabled by, first, setting the `CI_USE_ISVC_HOST=1` environment variable and, then invoking pytest. Thus, the original behavior of using Istio IngressGateway ClusterIP is the default one.

Signed-off-by: Edgar Hernández <[email protected]>

---------

Signed-off-by: Edgar Hernández <[email protected]>
* Upgraded poetry version to 1.7.1

Signed-off-by: Andrews Arokiam <[email protected]>

* fixed poetry install with invalid group.

python-poetry/poetry#7529

Signed-off-by: Andrews Arokiam <[email protected]>

---------

Signed-off-by: Andrews Arokiam <[email protected]>
… of transformer container port in transformer collocation (kserve#3318)

* Fix service points to predictor in raw deployment collocation

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Set readiness probe for transformer container

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add e2e test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* resolve comments

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Upgrade cloudevents to v2

Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
…and predictor (kserve#3280)

* Restrict storage uri to predictor only in transformer collocation

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add unit tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add e2e test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* fmt

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix e2e test debug info

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Improve quick install script

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update docs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* fix indentation on quick install

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* Add new storageUri schema "oci" that points to a OCI image
For that a new injector that adds a so-called "modelcar"
container to "kserve-container" as a sidecar has been added.
This setups a pod for sharing the process namespace
(shareProcessNamespace = true).

The following configuration options have been added:

* `enableModelcar` to switch on this feature (default: false)
* `cpuModelcar` and `memoryModelcar` to set the resources for the
   modelcar container
* `uidModelcar` for the UID to use for the user-container *and*
   the modelcar contained

See kserve#3110 for more information and
architecture of this feature.

Signed-off-by: Roland Huß <[email protected]>

* Fix merge

Signed-off-by: Dan Sun <[email protected]>

* Allow oci prefix

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Roland Huß <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* Add regex support for propagating IG headers

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Address comments

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Log headers that are propagated

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add test case for invalid pattern

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* resolve comments

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* chore: Prepare v0.12.0-rc0 release

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Dan Sun <[email protected]>

* python version should not contain dash

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Dan Sun <[email protected]>

* modelmeshVersion bump and python packages bump

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Dan Sun <[email protected]>

* Update helm values

Signed-off-by: Dan Sun <[email protected]>

* Update release

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* docs: Minor corrections/edits on release process

Signed-off-by: Yuan Tang <[email protected]>

* Update RELEASE_PROCESS_v2.md

Signed-off-by: Yuan Tang <[email protected]>

* Update RELEASE_PROCESS_v2.md

Signed-off-by: Yuan Tang <[email protected]>

* Update RELEASE_PROCESS_v2.md

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
…ixes kserve#3314 (kserve#3315)

* build: Switch to use kustomize in kubectl to simplify build process. Fixes kserve#3314

Signed-off-by: Yuan Tang <[email protected]>

* Update scripts in hack folder

Signed-off-by: Yuan Tang <[email protected]>

* Address comments

Signed-off-by: Yuan Tang <[email protected]>

* Revert incorrect change

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
…3301)

* feat: Expose defaults for several batcher handler parameters

Signed-off-by: Yuan Tang <[email protected]>

* fix: add timeout

Signed-off-by: Yuan Tang <[email protected]>

* Add new params to config/manifests

Signed-off-by: Yuan Tang <[email protected]>

* Remove timeout

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
…ixes kserve#3323 (kserve#3321)

* fix: Properly close resources and handle errors in agent and storage

Signed-off-by: Yuan Tang <[email protected]>

* reduce indentation

Signed-off-by: Yuan Tang <[email protected]>

* return early

Signed-off-by: Yuan Tang <[email protected]>

* return -> break

Signed-off-by: Yuan Tang <[email protected]>

* Address comments

Signed-off-by: Yuan Tang <[email protected]>

* newError -> closeErr

Signed-off-by: Yuan Tang <[email protected]>

* newError -> closeErr

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
yuzisun and others added 3 commits December 31, 2023 03:50
…3332)

* Update bert tokenizer example

Signed-off-by: Dan Sun <[email protected]>

* Generate id for infer request

Signed-off-by: Dan Sun <[email protected]>

* Fix model name in tests

Signed-off-by: Dan Sun <[email protected]>

* Fix model_name argument

Signed-off-by: Dan Sun <[email protected]>

* Fix predictor_protocol

Signed-off-by: Dan Sun <[email protected]>

* Generate request id if none 

Signed-off-by: Dan Sun <[email protected]>

* Set default None for PredictorConfig

Signed-off-by: Dan Sun <[email protected]>

* Add comment

Signed-off-by: Dan Sun <[email protected]>

* Enable doc with default values

Signed-off-by: Dan Sun <[email protected]>

* Add back add_help false 

Signed-off-by: Dan Sun <[email protected]>

* Update protocol choices

Signed-off-by: Dan Sun <[email protected]>

* Fix grpc-v2 choice

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Dan Sun <[email protected]>
* Update kserve python runtime API docstring

Signed-off-by: Dan Sun <[email protected]>

* Use InferenceError

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Dan Sun <[email protected]>
Copy link

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho
Copy link

Jooho commented Jan 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2d53808 into opendatahub-io:master Jan 4, 2024
26 checks passed
@spolti spolti deleted the sync branch January 4, 2024 18:55
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request Mar 1, 2024
…p/component-updates/kserve-agent-28

Update kserve-agent-28 to 24e1fc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants