s3 storage initializer: only set environment variables if variables are set in storage secret json #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting environment variables to the result of
.get(..., "")
, the corresponding env variables are set to an empty value.This is an issue for some values, such as
AWS_CA_BUNDLE
, which should be set to a path pointing to a valid CA bundle. When set to an empty string,it is propagated all the way down to
botocore.httpsession.URLLib3Session._setup_ssl_cert
,which interprets it as
False
and disables verification.See https://github.com/boto/botocore/blob/6e0ec833714ed88d46e294048cdb0d3869eb2ab5/botocore/httpsession.py#L376-L382
Feature/Issue validation/testing:
See the original issue on #137:
InsecureRequestWarning: Unverified HTTPS request
warnings were being printed when retrieving data from S3 (using https)Setting
AWS_CA_BUNDLE
to a non-null value gets rid of the warning.Release notes: