Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webhookClientConfig from inferenceservice crd of kserve #120

Merged
merged 1 commit into from
Nov 9, 2023
Merged

remove webhookClientConfig from inferenceservice crd of kserve #120

merged 1 commit into from
Nov 9, 2023

Conversation

VedantMahabaleshwarkar
Copy link

What this PR does / why we need it:
Remove webhook from inferenceservice crd in kserve as a patch as a workaround for the CRD conflict resulting in not being able to install modelmesh and kserve together.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes opendatahub-io/opendatahub-operator#573

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
DSC Spec:

spec:
  components:
    codeflare:
      devFlags: {}
    dashboard:
      devFlags:
        manifests:
          - contextDir: manifests
            sourcePath: overlays/incubation
            uri: 'https://github.com/opendatahub-io/odh-dashboard/tarball/incubation'
      managementState: Managed
    datasciencepipelines:
      devFlags: {}
    kserve:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: 'https://github.com/VedantMahabaleshwarkar/kserve/tarball/test'
          - contextDir: config
            sourcePath: ''
            uri: >-
              https://github.com/VedantMahabaleshwarkar/odh-model-controller/tarball/storage_secret_fix_test
      managementState: Managed
    modelmeshserving:
      devFlags: {}
      managementState: Managed
  • Test all permutations of install/uninstall kserve+modelmesh and check for any install time errors
    • e.g: enable kserve+modelmesh together, one at a time and the other next, uninstall one component while retaining the other etc

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
@openshift-ci openshift-ci bot requested review from Jooho and spolti November 8, 2023 19:27
@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@VedantMahabaleshwarkar VedantMahabaleshwarkar linked an issue Nov 8, 2023 that may be closed by this pull request
@spolti
Copy link
Member

spolti commented Nov 8, 2023

I am not sure if disabling stuff like you are proposing is a good idea.
As you mentioned the root cause already: opendatahub-io/opendatahub-operator#573 (comment)

it would need to be fixed in the KServe.

@VedantMahabaleshwarkar
Copy link
Author

@spolti

Yes this should be proposed upstream. We are planning on proposing it upstream as well. However we need this fix to be able to install Kserve and ModelMesh together for the upcoming release.

@Jooho Jooho changed the title remove webhook from inferenceservice crd remove webhookClientConfig from inferenceservice crd of kserve Nov 9, 2023
Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 9, 2023
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jooho,VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6bb6f80 into opendatahub-io:master Nov 9, 2023
19 checks passed
Jooho pushed a commit to Jooho/kserve that referenced this pull request Feb 28, 2024
…tudio-kserve-storage-initializer-28

Red Hat Konflux update kserve-storage-initializer-28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Resolve CRD conflict with ModelMesh Cannot deploy Kserve and Modelmesh together
3 participants