[RHOAIENG-16851] Remove component url temporarily

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
opendatahub-io · Jan 13, 2025 · ef6b4d6 · ef6b4d6
1 parent 8c95dac
commit ef6b4d6
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 27 deletions.
diff --git a/pkg/apis/serving/v1beta1/inference_service_status.go b/pkg/apis/serving/v1beta1/inference_service_status.go
@@ -336,9 +336,12 @@ func (ss *InferenceServiceStatus) PropagateRawStatus(
 	}
 
 	condition := getDeploymentCondition(deploymentList, appsv1.DeploymentAvailable)
-	if condition != nil && condition.Status == v1.ConditionTrue {
-		statusSpec.URL = url
-	}
+	// currently the component url is disabled as this url generated based on ingressConfig. This is incompatible with
+	// rawdeployment changes as the url depends on the route creation, if a route is requested.
+	// TODO: add back component url deterministicly
+	// if condition != nil && condition.Status == v1.ConditionTrue {
+	//	 statusSpec.URL = url
+	//}
 	readyCondition := readyConditionsMap[component]
 	ss.SetCondition(readyCondition, condition)
 	ss.Components[component] = statusSpec

diff --git a/pkg/controller/v1beta1/inferenceservice/rawkube_controller_test.go b/pkg/controller/v1beta1/inferenceservice/rawkube_controller_test.go
@@ -425,10 +425,10 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Components: map[v1beta1.ComponentType]v1beta1.ComponentStatusSpec{
 					v1beta1.PredictorComponent: {
 						LatestCreatedRevision: "",
-						URL: &apis.URL{
-							Scheme: "http",
-							Host:   "raw-foo-predictor-default.example.com",
-						},
+						//URL: &apis.URL{
+						//	Scheme: "http",
+						//	Host:   "raw-foo-predictor-default.example.com",
+						//},
 					},
 				},
 				ModelStatus: v1beta1.ModelStatus{
@@ -840,10 +840,10 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Components: map[v1beta1.ComponentType]v1beta1.ComponentStatusSpec{
 					v1beta1.PredictorComponent: {
 						LatestCreatedRevision: "",
-						URL: &apis.URL{
-							Scheme: "http",
-							Host:   "raw-foo-customized-predictor-default.example.com",
-						},
+						//URL: &apis.URL{
+						//	Scheme: "http",
+						//	Host:   "raw-foo-customized-predictor-default.example.com",
+						//},
 					},
 				},
 				ModelStatus: v1beta1.ModelStatus{
@@ -1246,10 +1246,10 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Components: map[v1beta1.ComponentType]v1beta1.ComponentStatusSpec{
 					v1beta1.PredictorComponent: {
 						LatestCreatedRevision: "",
-						URL: &apis.URL{
-							Scheme: "http",
-							Host:   "raw-foo-2-predictor-default.example.com",
-						},
+						//URL: &apis.URL{
+						//	Scheme: "http",
+						//	Host:   "raw-foo-2-predictor-default.example.com",
+						//},
 					},
 				},
 				ModelStatus: v1beta1.ModelStatus{
@@ -1723,10 +1723,10 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Components: map[v1beta1.ComponentType]v1beta1.ComponentStatusSpec{
 					v1beta1.PredictorComponent: {
 						LatestCreatedRevision: "",
-						URL: &apis.URL{
-							Scheme: "http",
-							Host:   fmt.Sprintf("%s-predictor-default.example.com", serviceName),
-						},
+						//URL: &apis.URL{
+						//	Scheme: "http",
+						//	Host:   fmt.Sprintf("%s-predictor-default.example.com", serviceName),
+						//},
 					},
 				},
 				ModelStatus: v1beta1.ModelStatus{
@@ -2156,10 +2156,10 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Components: map[v1beta1.ComponentType]v1beta1.ComponentStatusSpec{
 					v1beta1.PredictorComponent: {
 						LatestCreatedRevision: "",
-						URL: &apis.URL{
-							Scheme: "http",
-							Host:   fmt.Sprintf("%s-predictor.%s.%s", serviceName, serviceKey.Namespace, domain),
-						},
+						//URL: &apis.URL{
+						//	Scheme: "http",
+						//	Host:   fmt.Sprintf("%s-predictor.%s.%s", serviceName, serviceKey.Namespace, domain),
+						//},
 					},
 				},
 				ModelStatus: v1beta1.ModelStatus{
@@ -2659,10 +2659,10 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Components: map[v1beta1.ComponentType]v1beta1.ComponentStatusSpec{
 					v1beta1.PredictorComponent: {
 						LatestCreatedRevision: "",
-						URL: &apis.URL{
-							Scheme: "http",
-							Host:   "raw-auth-predictor-default.example.com",
-						},
+						//URL: &apis.URL{
+						//	Scheme: "http",
+						//	Host:   "raw-auth-predictor-default.example.com",
+						//},
 					},
 				},
 				ModelStatus: v1beta1.ModelStatus{