Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Update Python version of jupyterhub to Python 3.8 #115

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tmckayus
Copy link

@tmckayus tmckayus commented Sep 2, 2021

Related Issues and Dependencies

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

This PR changes the Python version to 3.8 in an image built from this repository

Description

Change the Python in the Pipfile and regenerate Pipfile.lock
Update a path in the .s2i/bin/assemble to reference Python 3.8 instead of 3.6
Change the import of distutils.util to work with Python 3.8

@tmckayus
Copy link
Author

tmckayus commented Sep 2, 2021

@vpavlin ptal

Note, this needs a jupyterhub-quickstart base image that use Python 3.8 as well so we'll have a corresponding PR.

@tmckayus tmckayus changed the title Update Python version of jupyterhub to Python 3.8 [WIP] Update Python version of jupyterhub to Python 3.8 Sep 2, 2021
@tmckayus
Copy link
Author

tmckayus commented Sep 2, 2021

@tmckayus
Copy link
Author

tmckayus commented Sep 2, 2021

Test images at:
quay.io/tmckayus/jupyterhub-odh:3.8 # built in openshift with the attached buildconfig
jupyterhub-38-json.txt

quay.io/tmckayus/jupyterhub-quickstart:3.8 # built with updated dockerfile from opendatahub-io-contrib/jupyterhub-quickstart#23

@tmckayus tmckayus changed the title [WIP] Update Python version of jupyterhub to Python 3.8 Update Python version of jupyterhub to Python 3.8 Sep 2, 2021
In order for a build of jupyterhub to work using Python 3.8,
we need a base image that also uses Python 3.8 which does
not formally exist yet. Use a test image for CI.
@vpavlin
Copy link

vpavlin commented Sep 3, 2021

/deploy

2 similar comments
@vpavlin
Copy link

vpavlin commented Sep 7, 2021

/deploy

@tmckayus
Copy link
Author

tmckayus commented Sep 7, 2021

/deploy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants