Add method for attempting dynamical region fetching for AWSSystemsManagerParameterStoreBackend #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| # Token is required for IMDSv2 | ||
| token_response = requests.put( | ||
| "http://169.254.169.254/latest/api/token", |
There was a problem hiding this comment.
I know it feels obvious due there is the AWS context around. But I would a comment about IP - what is it? where it comes from? etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 additional methods to retrieve was region for AWSSystemsManagerParameterStoreBackend.
Prioritisation of getting region:
If none of this worked - we put None, and get error as we can not setup boto3 connection.