Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed translation for mapping multiple nested references #1070

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Aug 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 84.63% // Head: 64.55% // Decreases project coverage by -20.07% ⚠️

Coverage data is based on head (29a5a60) compared to base (5e599d2).
Patch coverage: 79.10% of modified lines in pull request are covered.

❗ Current head 29a5a60 differs from pull request most recent head e963b4e. Consider uploading reports for the commit e963b4e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1070       +/-   ##
============================================
- Coverage    84.63%   64.55%   -20.08%     
============================================
  Files          557      541       -16     
  Lines        41363    50976     +9613     
============================================
- Hits         35008    32909     -2099     
- Misses        6355    18067    +11712     
Impacted Files Coverage Δ
stix_shifter_utils/utils/helpers.py 52.56% <63.15%> (-7.86%) ⬇️
...lation/src/json_to_stix/json_to_stix_translator.py 77.46% <83.78%> (-13.29%) ⬇️
...ix_translation/test_azure_sentinel_json_to_stix.py 42.23% <90.90%> (-57.77%) ⬇️
...ls/stix_translation/src/json_to_stix/observable.py 11.11% <0.00%> (-88.89%) ⬇️
...s/stix_translation/test_proofpoint_json_to_stix.py 27.16% <0.00%> (-70.75%) ⬇️
...s/stix_translation/test_aws_athena_json_to_stix.py 35.33% <0.00%> (-64.67%) ⬇️
...bereason/test/stix_transmission/test_cybereason.py 35.69% <0.00%> (-63.06%) ⬇️
...tix_translation/test_reversinglabs_json_to_stix.py 36.13% <0.00%> (-59.74%) ⬇️
...ests/stix_translation/test_cbcloud_json_to_stix.py 43.07% <0.00%> (-56.93%) ⬇️
... and 312 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@baulus baulus marked this pull request as ready for review September 9, 2022 12:23
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mdazam1942
❌ Arthur Muradyan


Arthur Muradyan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants