fix(migration): introduce conditionality and continue indexing on failure #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
Your environment is deployed to https://fixmigration-errors.opencrvs.dev |
Zangetsu101
requested changes
Oct 8, 2024
| @@ -67,7 +67,7 @@ export const up = async (db: Db, client: MongoClient) => { | |||
| const operationHistoriesData = | |||
| searchResult && | |||
| searchResult.body.hits.hits.length > 0 && | |||
| searchResult.body.hits.hits[0]._source?.operationHistories | |||
| searchResult.body.hits.hits?.[0]?._source?.operationHistories | |||
There was a problem hiding this comment.
Probably this is safer instead of the three lines here?
searchResult?.body?.hits?.hits?.[0]?._source?.operationHistories
| @@ -150,10 +151,10 @@ async function updateEventLocationIdOrJurisdictionIds(db: Db, elasticDoc: any) { | |||
| ) | |||
There was a problem hiding this comment.
Shouldn't this be similar to packages/migration/src/migrations/hearth/20221110092434-add_identifiers_DOB_gender_location.ts?
| @@ -150,10 +151,10 @@ async function updateEventLocationIdOrJurisdictionIds(db: Db, elasticDoc: any) { | |||
| ) | |||
|
|
|||
| if (locationDoc.length > 0) { | |||
| if (locationDoc[0].type.coding[0].code === 'HEALTH_FACILITY') { | |||
| body.eventLocationId = locationDoc[0].id | |||
| if (locationDoc?.[0]?.type?.coding?.[0]?.code === 'HEALTH_FACILITY') { | |||
There was a problem hiding this comment.
Suggested change
| if (locationDoc?.[0]?.type?.coding?.[0]?.code === 'HEALTH_FACILITY') { | |
| if (locationDoc[0].type?.coding?.[0]?.code === 'HEALTH_FACILITY') { |
as we just asserted that length is greater than zero 😄
naftis
reviewed
Oct 8, 2024
Zangetsu101
approved these changes
Oct 8, 2024
naftis
changed the title
makelicious
added a commit
that referenced
this pull request
Oct 8, 2024
🍒 Merge changes from PR #7742 to release-v1.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When running migrations, we assume arrays always contain at least one item. This results to failure during the process.
Fix:
Introduce conditional checks to remaining files, even if they might work without 99% of the time.
Issue:
Reindexing throws an error when single document fails to be indexed to elasticsearch.
Most likely the implicit schema that gets created prevents some of the items being added.
Fix:
Allow elasticsearch to drop the documents but keep track of them.