Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove the NID field from the system user add/edit form #7697

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Siyasanga
Copy link
Collaborator

Address the issues listed in ticket #6830 like:

  • Reordering the field to start with the user's surname
  • Rename "First name(s)" label to read "User's first name"
  • Rename "Last name" label to read as "User's surname"
  • Remove the NID field from the user's form
  • Write migration script to remove the NID value for all existing system Users

#6830

we often receive requests from countries to have the surname first in this form, we have decided to satisfy that requirement by putting surname first for ALL countries.

#6830
A request came for the clients to change the labels for "First name(s)" to "User's first name". Also change "Last name" to "User's surname" for clarity and less confussion.

#6830
Copy link

github-actions bot commented Oct 1, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Siyasanga Siyasanga self-assigned this Oct 1, 2024
@Siyasanga Siyasanga added this to the v1.7.0 milestone Oct 1, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-6830.opencrvs.dev.

@Siyasanga Siyasanga changed the title fix: Configurable human name formatting feat: Configurable human name formatting Oct 1, 2024
@Siyasanga Siyasanga marked this pull request as draft October 1, 2024 15:03
@Siyasanga
Copy link
Collaborator Author

Hi @rikukissa I've removed all references to the NID field, can you please have a look when you have some time. I'm currently writing the migration to remove the NID field for the already existing system users.

Remove the question that asks the user for a national ID number in this form as it is not required

#6830
@@ -79,38 +78,38 @@ export function userSectionFormType(): ISerializedFormSection {
title: userFormMessages.userDetails,
fields: [
{
name: 'firstNamesEng',
name: 'familyNameEng',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to change these to just familyName so dropping the Eng and En suffixes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rikukissa this is the problem that I was having with the test in relation to the request of renaming familyNameEng suffixes. In the mocked data example we already had familyName property and so trying to rename familyNameEng to FamilyName causes conflicts for the object.

Since we are not using it in the user-mgnt database anyways I thought deleting it familyName: 'হোসেন' and renaming the other to familyName: 'Hossain' would make sense would you agree?

Siyasanga Mtshokotsha added 2 commits October 8, 2024 23:59
We no longer need the suffixes for the FamilyName field since we not really using it anywhere

#6830
A requirement from client to remove the NID field since most of the contries are not really using it.

#6830
@Siyasanga Siyasanga changed the title feat: Configurable human name formatting feat: Remove the NID field from the system user add/edit form Oct 8, 2024
@Siyasanga Siyasanga linked an issue Oct 8, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Code Review
Development

Successfully merging this pull request may close these issues.

Configurable human name formatting
3 participants