fix(migration): fetch location when id is found during population. Cl…

…ean conditions
opencrvs · Oct 8, 2024 · e5321e9 · e5321e9
1 parent 70abbbc
commit e5321e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/...ages/migration/src/migrations/hearth/20230328065851-change-certified-status-to-issused.ts b/...ages/migration/src/migrations/hearth/20230328065851-change-certified-status-to-issused.ts
@@ -65,9 +65,7 @@ export const up = async (db: Db, client: MongoClient) => {
  const searchResult = await searchByCompositionId(compositionId)
 
  const operationHistoriesData =
- searchResult &&
- searchResult.body.hits.hits.length > 0 &&
- searchResult.body.hits.hits?.[0]?._source?.operationHistories
+ searchResult?.body?.hits?.hits?.[0]?._source?.operationHistories
  const lastOperationHistory =
  operationHistoriesData &&
  operationHistoriesData.length > 0 &&

diff --git a/packages/migration/src/migrations/hearth/20230602120944-populate-valid-locationid.ts b/packages/migration/src/migrations/hearth/20230602120944-populate-valid-locationid.ts
@@ -144,14 +144,14 @@ async function updateEventLocationIdOrJurisdictionIds(db: Db, elasticDoc: any) {
  ''
  )
 
- const locationDoc = await getCollectionDocuments(
- db,
- COLLECTION_NAMES.LOCATION,
- [locationId]
- )
+ const locationDoc = locationId
+ ? await getCollectionDocuments(db, COLLECTION_NAMES.LOCATION, [
+  locationId
+  ])
+  : []
 
  if (locationDoc.length > 0) {
- if (locationDoc?.[0]?.type?.coding?.[0]?.code === 'HEALTH_FACILITY') {
+ if (locationDoc[0].type?.coding?.[0]?.code === 'HEALTH_FACILITY') {
  body.eventLocationId = locationDoc[0]?.id
  } else {
  const address = locationDoc[0]?.address