Merge pull request #7736 from opencrvs/prevent-extra-space-in-person-…

…name-notification fix: prevent extra space in person name in notification content
opencrvs · Oct 8, 2024 · 85bb329 · 85bb329
2 parents cb47ef2 + fede711
commit 85bb329
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/trigger-e2e-environment.yml b/.github/workflows/trigger-e2e-environment.yml
@@ -79,7 +79,8 @@ jobs:
  .trim()
  .replace(/\s+/g, '-')
  .replace(/-+/g, '-')
- .substr(0, 35);
+ .substr(0, 35)
+ .replace(/[^a-zA-Z0-9]+$/g, '');
  }
  const result = await github.rest.repos.createDispatchEvent({
  owner: 'opencrvs',

diff --git a/packages/notification/src/features/utils.ts b/packages/notification/src/features/utils.ts
@@ -117,7 +117,7 @@ export function getPersonName(
  if (!name) {
  error(record, `name not found in patient resource for ${compositionCode}`)
  }
- return [name.given?.join(' '), name.family].join(' ').trim()
+ return [name.given?.join(' ').trim(), name.family].join(' ').trim()
 }
 
 export function getRegistrationLocation(