Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.1 #4500

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Release v1.2.1 #4500

merged 2 commits into from
Nov 1, 2024

Conversation

rata
Copy link
Member

@rata rata commented Nov 1, 2024

I propose to release 1.2.1 early next week TODAY (see comment asking for it here: #4500 (review)). containerd needs the fixes here to properly update to the 1.2.x branch.


[1.2.1] - 2024-11-05

No existe una escuela que enseñe a vivir.

Fixed

Changed

@rata
Copy link
Member Author

rata commented Nov 1, 2024

Grrr, codespell is failing because it wants to correct spanish, that is written properly -.-. Changed it to another phrase now.

@rata rata changed the title Release 1.2.1 Release v1.2.1 Nov 1, 2024
@rata rata force-pushed the rata/release-1.2.1 branch 2 times, most recently from cc235d6 to fb01b7a Compare November 1, 2024 17:04
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kolyshkin kolyshkin added this to the 1.2.1 milestone Nov 1, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@rata rata force-pushed the rata/release-1.2.1 branch 2 times, most recently from 0db3570 to 56053ab Compare November 1, 2024 18:07
@rata rata requested a review from kolyshkin November 1, 2024 18:08
@rata
Copy link
Member Author

rata commented Nov 1, 2024

Updated the release date for TODAY, as @AkihiroSuda asked

@rata
Copy link
Member Author

rata commented Nov 1, 2024

Also, please feel free to push to this branch if you want to release today (maintainers can push). It's quite late here, I won't be online much longer.

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll prep the release.

@cyphar
Copy link
Member

cyphar commented Nov 1, 2024

You forgot to update VERSION in the release commit. Pushing a fix...

Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Aleksa Sarai <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
@cyphar cyphar merged commit 7a8738e into opencontainers:release-1.2 Nov 1, 2024
40 checks passed
@cyphar
Copy link
Member

cyphar commented Nov 1, 2024

https://github.com/opencontainers/runc/releases/tag/v1.2.1

@h-vetinari
Copy link

Congratulations on the release! Just two comments from reading the release notes

Fixed

  • Became root after [...]

The release notes don't have the "Fixed" header, and so the sentence starting with "Became root" is pretty hard to make sense of.

Also, the current release notes say (my emphasis)

In addition, runc-dmz (added in 1.2.0) has been removed entirely. This was opt-out (due to the many limitations it had)

which should probably say "opt-in", c.f. the following from the OP

Note that runc-dmz was only available only in the 1.2.0 release and required to set an environment variable to opt-in.

@cyphar
Copy link
Member

cyphar commented Nov 4, 2024

@h-vetinari Fixed. Turns out I can't proofread properly late at night... 😅

@rata rata deleted the rata/release-1.2.1 branch November 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants