bump golangci-lint; remove nolint annotations for unix errno comparisons #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually errorlint allows io.EOF comparison (based on a whitelist of functions that can return bare io.EOF), thus there is no need for nolint annotation. In this very case, though, the need for nolint is caused by issue with errorlint, which fails to see where err is coming from. Refer to the issue so when it is fixed we can remove the annotation. Signed-off-by: Kir Kolyshkin <[email protected]>
Currently, it is at v1.54.2. Signed-off-by: Kir Kolyshkin <[email protected]>
golangci-lint v1.54.2 comes with errorlint v1.4.4, which contains the fix [1] whitelisting all errno comparisons for errors coming from x/sys/unix. Thus, these annotations are no longer necessary. Hooray! [1] polyfloyd/go-errorlint#47 Signed-off-by: Kir Kolyshkin <[email protected]>
AkihiroSuda
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint v1.54.2 comes with errorlint v1.4.4, which contains
the fix (polyfloyd/go-errorlint#47) whitelisting all errno comparisons for errors coming from
x/sys/unix.
Thus, these annotations are no longer necessary. Hooray!