Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openconfig-mpls-te.yang #926

Merged
merged 10 commits into from
Sep 6, 2023
Merged

Update openconfig-mpls-te.yang #926

merged 10 commits into from
Sep 6, 2023

Conversation

mryuezhang
Copy link
Contributor

@mryuezhang mryuezhang commented Jul 26, 2023

Fixes #889

Change Scope

  • Added a leaf to MPLS P2P tunnels to enable/disable record-route
  • This change is backwards compatible

Platform Implementation

Added leaf  record-record-enabled under grouping tunnel-p2p-attributes-config.
@mryuezhang mryuezhang requested a review from a team as a code owner July 26, 2023 02:07
@google-cla
Copy link

google-cla bot commented Jul 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OpenConfigBot
Copy link

OpenConfigBot commented Jul 26, 2023

Major YANG version changes in commit 16ac139:

@OpenConfigBot
Copy link

OpenConfigBot commented Jul 26, 2023

Compatibility Report for commit 16ac139:
pyangbind@6b85c2b

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update leaf names

release/models/mpls/openconfig-mpls-te.yang Outdated Show resolved Hide resolved
release/models/mpls/openconfig-mpls.yang Outdated Show resolved Hide resolved
release/models/mpls/openconfig-mpls-te.yang Outdated Show resolved Hide resolved
@mryuezhang mryuezhang requested a review from dplore August 9, 2023 14:10
@dplore
Copy link
Member

dplore commented Aug 15, 2023

Thanks @mryuezhang ! As a last step, OpenConfig requires providing references to the documentation for at least two implementations of this change. An example is #941

@jhaas-pfrc
Copy link

jhaas-pfrc commented Aug 15, 2023

Note that Junos has RRO on by default.
Since this leaf does not specify a default, it doesn't interfere with existing operations. It provides access to the state of this feature, and provides the ability to disable it explicitly - if desired.

https://www.juniper.net/documentation/us/en/software/junos/mpls/topics/ref/statement/record-edit-protocols-mpls.html

@mryuezhang
Copy link
Contributor Author

Thanks @mryuezhang ! As a last step, OpenConfig requires providing references to the documentation for at least two implementations of this change. An example is #941

Added.

@dplore dplore self-assigned this Aug 17, 2023
@dplore dplore added the last-call PR that is in final review before merging. label Aug 17, 2023
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version numbers and then we will be ready to merge.

release/models/mpls/openconfig-mpls-igp.yang Outdated Show resolved Hide resolved
@mryuezhang mryuezhang requested a review from dplore August 19, 2023 19:38
@dplore dplore merged commit a6fd34d into openconfig:master Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call PR that is in final review before merging. non-breaking
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

How to Enable Record Route for MPLS Tunnels(LSPs)
4 participants