Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bfd diagnostic code for when neighbor signaled session down. #1233

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AnilKR123
Copy link
Contributor

Change Scope

I have added a Bfd diagnostic code for when neighbor signals session down. This is specified in RFC5880 but is absent from the public model.

From RFC5880:

 A diagnostic code specifying the local system's reason for the
  last change in session state.  Values are:

     0 -- No Diagnostic
     1 -- Control Detection Time Expired
     2 -- Echo Function Failed
     3 -- Neighbor Signaled Session Down
     4 -- Forwarding Plane Reset
     5 -- Path Down
     6 -- Concatenated Path Down
     7 -- Administratively Down
     8 -- Reverse Concatenated Path Down

@AnilKR123 AnilKR123 requested a review from a team as a code owner December 16, 2024 23:06
@@ -157,35 +164,41 @@ module openconfig-bfd {
"The BFD echo function failed - echo packets have not been
received for the required period of time.";
}
enum FORWARDING_RESET {
enum NEIGHBOR_DOWN {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this as a non-breaking change, the original ordering of the enums must be preserved. You can only add enums to the list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize the enum value won't match the value in a packet on the wire, but that is not required.

@AnilKR123
Copy link
Contributor Author

I moved NEIGHBOR_DOWN to the end of the enums list.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to discuss
Development

Successfully merging this pull request may close these issues.

2 participants