Merge branch 'master' into master

doc/Integrated-Circuit_pipeline_aggregated_counters_guide.md

@@ -0,0 +1,72 @@
+# Intergrated Circuit aggregated pipeline counters guide
+## Introduction
+This guide discusses semantics of different counters provided under the
+`openconfig-platform/components/component/integrated-circuit/pipeline-counters` container.
+The `INTEGRATED_CIRCUIT` or I-C, in this document refers to the OpenConfig [INTEGRATED_CIRCUIT](https://github.com/openconfig/public/blob/5d38d8531ef9c5b998262207eb6dbdae8968f9fe/release/models/platform/openconfig-platform-types.yang#L346) component type which is typically an ASIC or NPU (or combination of both) that provides packet processing capabilities.
+
+## Per-block packets/octets counters
+[TODO] more detailed description
+## Drop packets/octets counters
+The `/components/component/integrated-circuit/pipeline-counters/drop` container collects counters related to packets dropped by the `INTEGRATED_CIRCUIT`.
+### Aggregated drop counters
+These 4 counters should cover all packets dropped by the IC which are not already covered by the /interfaces tree.   For example, a packet which is dropped due to QoS policy for WRED should be counted only by the appropriate /interfaces path [dropped-pkts](https://github.com/openconfig/public/blob/5d38d8531ef9c5b998262207eb6dbdae8968f9fe/release/models/qos/openconfig-qos-interfaces.yang#L375).    
+
+Aggregated drop counters are modeled as below:
+```
+module: openconfig-platform
+  +--rw components
+     +--rw component* [name]
+        +--rw integrated-circuit
+           +--ro oc-ppc:pipeline-counters
+              +--ro oc-ppc:drop
+                 +--ro oc-ppc:state
+                    +--ro oc-ppc:adverse-aggregate?             oc-yang:counter64
+                    +--ro oc-ppc:congestion-aggregate?          oc-yang:counter64
+                    +--ro oc-ppc:packet-processing-aggregate?   oc-yang:counter64
+                    +--ro oc-ppc:urpf-aggregate?                oc-yang:counter64
+```
+#### urpf-aggregate
+
+##### Usability
+The increments of this counter are typically signal of some form of attack with spoofed source address. Typically dDOS class.
+
+#### packet-processing-aggregate
+
+##### Usability
+The increments of this counter are expected during convergence events as well as during stable operation. However rapid increase in drop rate **may** be a signal of network being unhealthy and typically requires further investigation. 
+The further break down of this counter, if available as vendor extension under `/openconfig-platform:components/component/integrated-circuit/openconfig-platform-pipeline-counters:pipeline-counters/drop/vendor` container could help to further narrow-down cause of drops. 
+
+If prolonged packet drops are found to be caused by lack of FIB entry for incomming packets, this suggest inconsistency between Network Control plane protocols (BGP, IGP, RSVP, gRIBI), FIB calculated by Controller Card and FIB programmed into given Integrated Circuit.
+
+If implemetation supports `urpf-aggregate` counter, packets discarded due to uRPF should not be counted as `packet-processing-aggregate`. Else, uRPF discarded oacket should be counted against this counter.
+
+#### congestion-aggregate
+
+
+##### Usability
+The increments of this counter are signal of given Integrated Circuit being overhelmed by incomming traffic and complexity of packet processing that is required. 
+
+#### adverse-aggregate
+##### Usability
+The increments of this counter are generally a signal of a hardware defect (e.g. memory errors or signal integrity issues) or (micro)code software defects. 
+
+#### Queue tail and AQM drops exeption discussion.
+Drops associated with QoS queue tail or AQM are the result of egress interface congestion.   This is NOT the same as I-C congestion, and should be counted using /interfaces counters as it is expected state from the platform (router) point of view. It may be not expected state from a network design point of view but from the INTEGRATED_CIRCUIT, it is behaving according to design.   
+
+The OpenConfig definition for [congestion-aggregate](https://github.com/openconfig/public/blob/5d38d8531ef9c5b998262207eb6dbdae8968f9fe/release/models/platform/openconfig-platform-pipeline-counters.yang#L1096-L1099) excludes "queue drop counters". It desirable to  not count QoS queue drops under this `congestion-aggregate` in order to maintain a clear signal of hitting I-C performance limitations, rather then blend it with basic, simple egress interface speed limitations.
+
+### Per-Block drop copunters
+[TODO] more detailed description for standard OpenConfig drop counters defined for Interface-, Lookup-, Queueing-, Fabric-  and Host-Interface- blocks. Also discuss relationship with Control plane traffic packets/octets counters.
+### Vendor extensions
+Please refer to [Vendor-Specific Augmentation for Pipeline Counter](vendor_counter_guide.md)
+## Error counters
+These leafs **do not** count **packets or bytes**.
+They count error events.
+
+For example corruption of on chip, HBM or chip external memory buffers (soft-error) which also are not already counted as queue drops for interfaces.
+
+[TODO] more detailed description
+## Control plane traffic packets/octets counters
+[TODO] more detailed description. Also discuss relationship with Host-Interface block counters.
+### Standard OpenConfig counters
+### Vendor extensions

release/models/interfaces/openconfig-interfaces.yang

@@ -51,7 +51,15 @@ module openconfig-interfaces {
     Section 4.c of the IETF Trust's Legal Provisions Relating
     to IETF Documents (http://trustee.ietf.org/license-info).";
 
-  oc-ext:openconfig-version "3.6.0";
+  oc-ext:openconfig-version "3.7.0";
+
+  revision "2023-11-06" {
+      description
+        "Clarify description for admin-status TESTING.";
+      reference
+        "3.7.0";
+  }
+
   revision "2023-08-29" {
       description
         "Add augment for penalty-based additive-increase, exponential-decrease link damping algorithm.";
@@ -600,11 +608,16 @@ module openconfig-interfaces {
             "Not ready to pass packets and not in some test mode.";
         }
         enum TESTING {
-          //TODO: This is generally not supported as a configured
-          //admin state, though it's in the standard interfaces MIB.
-          //Consider removing it.
           description
-            "In some test mode.";
+            "The interface should be treated as if in admin-down state for
+            control plane protocols.  In addition, while in TESTING state the
+            device should remove the interface from aggregate interfaces.
+            An interface transition to the TESTING state based on a qualification
+            workflow, or internal device triggered action - such as the gNOI Link
+            Qualification service";
+            reference
+              "gNOI Link Qualification Service
+               https://github.com/openconfig/gnoi/blob/main/packet_link_qualification/index.md";
         }
       }
       //TODO:consider converting to an identity to have the
@@ -636,7 +649,7 @@ module openconfig-interfaces {
         enum TESTING {
           value 3;
           description
-            "In some test mode.  No operational packets can
+            "In test mode.  No operational packets can
              be passed.";
         }
         enum UNKNOWN {

release/models/platform/openconfig-platform-pipeline-counters.yang

@@ -65,10 +65,16 @@ module openconfig-platform-pipeline-counters {
     5 blocks, is to have the abililty to receive all drop counters from
     all 5 blocks, for example, with one request.";
 
-  oc-ext:openconfig-version "0.5.0";
+  oc-ext:openconfig-version "0.5.1";
   oc-ext:catalog-organization "openconfig";
   oc-ext:origin "openconfig";
 
+  revision "2023-10-08" {
+    description
+      "More detail description of pipe-line aggregated drop counters";
+    reference "0.5.1";
+  }
+
   revision "2023-09-26" {
     description
       "Add no-route aggregate drop counter.";
@@ -1093,7 +1099,18 @@ module openconfig-platform-pipeline-counters {
         "This captures the aggregation of all counters where the switch is
         unexpectedly dropping packets. Occurrence of these drops on a stable
         (no recent hardware or config changes) and otherwise healthy
-        switch needs further investigation.";
+        switch needs further investigation.
+        This leaf counts packet discarded as result of corrupted
+        programming state in an INTEGRATED_CIRCUIT or corrupted data
+        structures of packet descriptors.
+
+        Note: corrupted packets received on ingress interfaces should be counted
+        in `/interfaces/interface/state/counters/in-errors` and NOT counted as
+        adverse-aggregate. This is because incoming corrupted packets are NOT
+        a signal of adverse state of an INTEGRATED_CIRCUIT but rather of an
+        entity adjacent to the Interface, such as a cable or transceiver). Therefore
+        such drops SHOULD NOT be counted as adverse-aggregate to preserve
+        a clean signal of INTEGRATED_CIRCUIT adverse state.";
     }
 
     leaf congestion-aggregate {
@@ -1102,15 +1119,57 @@ module openconfig-platform-pipeline-counters {
         "This tracks the aggregation of all counters where the expected
         conditions of packet drops due to internal congestion in some block of
         the hardware that may not be visible in through other congestion
-        indicators like interface discards or queue drop counters.";
+        indicators like interface discards or queue drop counters.
+
+        This leaf counts packet discarded as result of exceeding
+        performance limits of an INTEGRATED_CIRCUT, when it processes
+        non-corrupted packets using legitimate, non-corrupted programming
+        state of the INTEGRATED_CIRCUIT.
+
+        The typical example is overloading given IC with higher packet rate (pps)
+        then given chip can handle. For example, let's assume chip X can process
+        3.6Bpps of incoming traffic and 2000 Mpps. However if average incoming
+        packet size is 150B, at full ingress rate this become 3000Mpps. Hence
+        1/3 of packets would be cropped and should be counted against
+        congestion-aggregate.
+
+        Another example is the case when some INTEGRATED_CIRCUIT internal data bus is
+        too narrow/slow for handling traffic. For example let's assume chip X needs to send
+        3Tbps of traffic to an external buffer memory which has only 2Tbps access I/O.  In
+        this case packets would be discarded, because of congestion of memory I/O bus
+        which is part of the INTEGRATED_CIRCUIT.  Depending on the design of the
+        INTEGRATED_CIRCUIT, packets could be discarded even if interface queues are
+        not full, hence this scenario is NOT treated as QoS queue tail-drops nor WRED drops.
+
+        Yet another example is the case where extremely large and long
+        ACL/filter requires more cycles to process than the INTEGRATED_CIRCUIT
+        has budgeted. ";
     }
 
     leaf packet-processing-aggregate {
       type oc-yang:counter64;
       description
         "This aggregation of counters represents the conditions in which
         packets are dropped due to legitimate forwarding decisions (ACL drops,
-        No Route etc.)";
+        No Route etc.)
+        This counter counts packet discarded as result of processing
+        non-corrupted packet against legitimate, non-corrupted state
+        of INTEGRATED_CIRCUIT program (FIB content, ACL content, rate-limiting token-buckets)
+        which mandate packet drop. The examples of this class of discard are:
+        - dropping packets which destination address to no match any FIB entry
+        - dropping packets which destination address matches FIB entry pointing
+        to discard next-hop (e.g. route to null0)
+        - dropping packts due to ACL/packet filter decission
+        - dropping packets due to its TTL = 1
+        - dropping packets due to its size exceeds egress interface MTU and
+        packet can't be fragmented (IPv6 or do not fragment bit is set)
+        -  dropping packets due to uRPF rules (note: packet is counted here and
+        in separate, urpf-aggregate counter simultaneously)
+        - etc
+
+      Note:The INTEGRATED_CIRCUIT is doing exactly what it is programmed
+      to do, and the packet is parsable.
+      ";
     }
 
     leaf urpf-aggregate {
@@ -1119,7 +1178,12 @@ module openconfig-platform-pipeline-counters {
         "This aggregation of counters represents the conditions in which
         packets are dropped due to failing uRPF lookup check.  This counter
         and the packet-processing-aggregate counter should be incremented
-        for each uRPF packet drop.";
+        for each uRPF packet drop.
+        This counter counts packet discarded as result of Unicast Reverse
+        Path Forwarding verification.";
+      reference
+        "RFC2827: Network Ingress Filtering: Defeating Denial of Service Attacks which employ IP Source Address Spoofing
+        RFC3704: Ingress Filtering for Multihomed Networks";
     }
 
     leaf no-route {