Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file perm for kubecfg creation when using kubeadm #507

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix file perm for kubecfg creation when using kubeadm #507

merged 1 commit into from
Mar 20, 2024

Conversation

alexmasi
Copy link
Contributor

This was not a critical change but it more closely matches the file perms by default and satisfies the linter.

@alexmasi alexmasi requested a review from guoshiuan March 20, 2024 15:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8361938738

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 65.176%
Totals Coverage Status
Change from base Build 8361430143: 0.02%
Covered Lines: 4488
Relevant Lines: 6886
💛 - Coveralls

@alexmasi alexmasi merged commit fd74351 into main Mar 20, 2024
8 of 9 checks passed
@alexmasi alexmasi deleted the perm branch March 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexmasi @coveralls @guoshiuan