Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubeadm cluster support to kne deploy #504

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Add kubeadm cluster support to kne deploy #504

merged 6 commits into from
Mar 19, 2024

Conversation

alexmasi
Copy link
Contributor

@alexmasi alexmasi commented Mar 13, 2024 •
edited
Loading

This adds the functionality for kne deploy to create a kubeadm cluster. Follow up PR will add the ability to join an existing cluster.

@coveralls
Copy link

coveralls commented Mar 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8345406494

Details

  • 45 of 96 (46.88%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 66.213%
Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 45 96 46.88%
Totals Coverage Status
Change from base Build 8299988429: -0.3%
Covered Lines: 4382
Relevant Lines: 6618
💛 - Coveralls

@alexmasi
Copy link
Contributor Author

TODO: add tests

@alexmasi alexmasi changed the title add kubeadm cluster support to kne deploy Add kubeadm cluster support to kne deploy Mar 15, 2024
@alexmasi alexmasi marked this pull request as ready for review March 18, 2024 20:26
@alexmasi alexmasi requested a review from bormanp March 18, 2024 20:26
bormanp
bormanp reviewed Mar 18, 2024
View reviewed changes
deploy/deploy.go Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
@alexmasi alexmasi merged commit cca81b4 into main Mar 19, 2024
11 of 12 checks passed
@alexmasi alexmasi deleted the kubeadm branch March 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bormanp bormanp bormanp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexmasi @coveralls @bormanp