Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Drivenets vendor #480

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

davnerson-dn
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Jan 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@davnerson-dn
Copy link
Contributor Author

/gcbrun

@davnerson-dn davnerson-dn force-pushed the dav/pr_to_official branch 14 times, most recently from df047c3 to 65faf27 Compare January 30, 2024 09:38
@davnerson-dn davnerson-dn force-pushed the dav/pr_to_official branch 9 times, most recently from 02b5194 to 9f15188 Compare February 7, 2024 13:18
@davnerson-dn davnerson-dn force-pushed the dav/pr_to_official branch 2 times, most recently from 3e0872a to 7686d5f Compare March 11, 2024 13:17
@davnerson-dn
Copy link
Contributor Author

/gcbrun

@davnerson-dn davnerson-dn force-pushed the dav/pr_to_official branch 2 times, most recently from bb91e6e to 4677d27 Compare March 17, 2024 16:09
@davnerson-dn davnerson-dn force-pushed the dav/pr_to_official branch 3 times, most recently from e0aa86d to 8a3329b Compare March 17, 2024 19:37
@alexmasi
Copy link
Contributor

Looks like you'll need to go mod tidy and go fmt ./...

After all of the presubmits are passing I'll take another look and launch the final presubmit

@davnerson-dn
Copy link
Contributor Author

i applied go mod tidy and go fmt ,
how to retrigger the presubmit ?

@alexmasi
Copy link
Contributor

The presubmits should trigger automatically after your first PR, sorry

@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8357146892

Details

  • 102 of 267 (38.2%) changed or added relevant lines in 2 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 65.176%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 22 33 66.67%
topo/node/drivenets/drivenets.go 80 234 34.19%
Files with Coverage Reduction New Missed Lines %
deploy/deploy.go 16 56.23%
Totals Coverage Status
Change from base Build 8345806477: -1.0%
Covered Lines: 4488
Relevant Lines: 6886

💛 - Coveralls

topo/node/drivenets/drivenets_test.go Outdated Show resolved Hide resolved
topo/node/drivenets/drivenets.go Outdated Show resolved Hide resolved
proto/controller.proto Outdated Show resolved Hide resolved
manifests/controllers/cdnos/manifest.yaml Show resolved Hide resolved
examples/drivenets/cdnos.pb.txt Outdated Show resolved Hide resolved
@alexmasi
Copy link
Contributor

Okay looks like the presubmits were addressed, I've left my last wave of review comments. After those are addressed, we should be good to merge.

@alexmasi
Copy link
Contributor

/gcbrun

@alexmasi
Copy link
Contributor

/gcbrun

@alexmasi
Copy link
Contributor

LGTM, will merge assuming the kne-presubmit passes. It appears the linter is currently broken so will not block on that failure.

@alexmasi alexmasi merged commit ed02645 into openconfig:main Mar 20, 2024
4 of 5 checks passed
@alexmasi
Copy link
Contributor

Thanks David for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants