-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Drivenets vendor #480
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
df047c3
to
65faf27
Compare
02b5194
to
9f15188
Compare
9f15188
to
c58f210
Compare
c58f210
to
30f3fdf
Compare
3e0872a
to
7686d5f
Compare
/gcbrun |
bb91e6e
to
4677d27
Compare
e0aa86d
to
8a3329b
Compare
8a3329b
to
c40b7b0
Compare
Looks like you'll need to After all of the presubmits are passing I'll take another look and launch the final presubmit |
i applied |
The presubmits should trigger automatically after your first PR, sorry |
Pull Request Test Coverage Report for Build 8357146892Details
💛 - Coveralls |
Okay looks like the presubmits were addressed, I've left my last wave of review comments. After those are addressed, we should be good to merge. |
/gcbrun |
1f639fa
to
079b92b
Compare
/gcbrun |
LGTM, will merge assuming the kne-presubmit passes. It appears the linter is currently broken so will not block on that failure. |
Thanks David for the contribution! |
No description provided.