Wait for manifest-issued deployments to complete before proceeding wi…

…th Topology generation (#556)

adding fix

deploy/deploy.go

@@ -707,6 +707,17 @@ func (k *KindSpec) Deploy(ctx context.Context) error {
 		}
 	}
 
+	// If any additional manifests were provided, there is a chance they started new deployment, e.g.,
+	// a manifest file might deploy a webhook that needs to be running before proceeding with later
+	// stages such as topology creation. Hence, we Wait for any potential deployments to complete.
+	// If no deployments were configured, the waiting status call simply returns immediately with a
+	// "No resources found in default namespace." error message that we should warn about.
+	if len(k.AdditionalManifests) > 0 {
+		log.Infof("Waiting for potential manifest-issued deployments to complete")
+		if err := run.LogCommand("kubectl", "rollout", "status", "deployment", "-w"); err != nil {
+			log.Warningf("Unable to wait for deployments to complete: %w", err)
+		}
+	}
 	return nil
 }
 

deploy/deploy_test.go

@@ -311,6 +311,7 @@ func TestKindSpec(t *testing.T) {
 			{Cmd: "docker", Args: []string{"tag", "docker", "local"}, OutOfOrder: true},
 			{Cmd: "docker", Args: []string{"pull", "gar"}, OutOfOrder: true},
 			{Cmd: "docker", Args: []string{"tag", "gar", "docker"}, OutOfOrder: true},
+			{Cmd: "kubectl", Args: []string{"rollout", "status", "deployment", "-w"}},
 		},
 	}, {
 		desc: "failed create cluster load containers additional manifests",