added breakout config test #3546
Conversation
Pull Request Functional Test Report for #3546 / 95e83a6Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 11579508590Details
💛 - Coveralls |
|
/check |
# Conflicts: # internal/deviations/deviations.go # proto/metadata.proto # proto/metadata_go_proto/metadata.pb.go
| breakoutContainer := &oc.Component_Port{BreakoutMode: groupContainer} | ||
| portContainer := &oc.Component{Port: breakoutContainer, Name: ygot.String(componentName)} | ||
|
|
||
| if deviations.VerifyExpectedBreakoutSupportedConfig(dut) { |
There was a problem hiding this comment.
not sure why this deviation is needed. if breakout config is not supported. then the test should fail right?
There was a problem hiding this comment.
if this applies only for 2x100G, pls add a comment to call it out explicitly/indicate in the deviation title
There was a problem hiding this comment.
this is not just for 2x100 it could be any combination of breakout. were using Cisco CLI here to check supported breakout speed for a given interface optic so we don't just blindly run unsupported modes which will cause failures and unnecessary triages. So we just run show controllers phy breakout interface and compare that with what breakout mode were attempting to configure on that port if its not a supported mode then we skip it. So in this case I used it for 2x100 as that is something i did not have at the time, but would apply to any breakout combination.
`show controllers phy breakout interface
Wed Oct 30 22:50:05.315 UTC
Supported Breakout Type is : OPTICS_BO_TYPE_4x100G
Is Port Mode Config Needed : FALSE`
Test is for breakout config for the following modes