Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGT-1 Add vendor changes #2898

Merged
merged 5 commits into from
May 1, 2024
Merged

MGT-1 Add vendor changes #2898

merged 5 commits into from
May 1, 2024

Conversation

MarcCharlebois
Copy link
Contributor

@MarcCharlebois MarcCharlebois commented Apr 16, 2024

  • Add createInterfaces() to ensure interfaces are created prior to assigning to VRF
  • Remove setNoPeerGroup / conditional statement - Added deviation for setNoPeerGroup
  • Enabled BGP global AFISAFI to BGP configs (REF: Adding vendor support for RT-1.19 #2420)
  • Added 3s sleep for Port2 test to ensure AFTs update
  • Add deviation TableConnectionsUnsupported (Ref: b/293508329)
  • Changed BatchReplace to BatchUpdate to ensure route redistribution policy remains.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Ref: b/333419511

- Add createInterfaces() to ensure interfaces are created prior to assigning to VRF
- Remove setNoPeerGroup / conditional statement
- Enabled BGP global AFISAFI to BGP configs (REF: openconfig#2420)
- Added 3s sleep for Port2 test to ensure AFTs update
- Add 2 deviations SetRoutePrefNative, TableConnectionsUnsupported
- Changed BatchReplace to BatchUpdate to ensure route redistribution policy remains.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@OpenConfigBot
Copy link

OpenConfigBot commented Apr 16, 2024

Pull Request Functional Test Report for #2898 / 3e93e2a

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
MGT-1: Management HA solution test
Cisco 8000E status
MGT-1: Management HA solution test
Cisco XRd status
MGT-1: Management HA solution test
Juniper ncPTX status
MGT-1: Management HA solution test
Nokia SR Linux status
MGT-1: Management HA solution test
Openconfig Lemming status
MGT-1: Management HA solution test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
MGT-1: Management HA solution test
Cisco 8808 status
MGT-1: Management HA solution test
Juniper PTX10008 status
MGT-1: Management HA solution test
Nokia 7250 IXR-10e status
MGT-1: Management HA solution test

Help

@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8884077808

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.448%

Totals Coverage Status
Change from base Build 8876484813: 0.0%
Covered Lines: 1949
Relevant Lines: 3515

💛 - Coveralls

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
Fix Merge Conflict + Add deviation for SetNoPeerGroup
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@cfernanz cfernanz merged commit bc60ccd into openconfig:main May 1, 2024
13 checks passed
@LimeHat LimeHat deleted the mc-mgt1 branch May 1, 2024 16:33
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request May 2, 2024
* Add vendor changes
- Add createInterfaces() to ensure interfaces are created prior to assigning to VRF
- Remove setNoPeerGroup / conditional statement
- Enabled BGP global AFISAFI to BGP configs (REF: openconfig#2420)
- Added 3s sleep for Port2 test to ensure AFTs update
- Add 2 deviations SetRoutePrefNative, TableConnectionsUnsupported
- Changed BatchReplace to BatchUpdate to ensure route redistribution policy remains.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Remove Deviation for nativepreference
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* remove dev from metadata.textproto
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Fixed typo in deviation function
“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Jul 10, 2024
* Add vendor changes
- Add createInterfaces() to ensure interfaces are created prior to assigning to VRF
- Remove setNoPeerGroup / conditional statement
- Enabled BGP global AFISAFI to BGP configs (REF: openconfig#2420)
- Added 3s sleep for Port2 test to ensure AFTs update
- Add 2 deviations SetRoutePrefNative, TableConnectionsUnsupported
- Changed BatchReplace to BatchUpdate to ensure route redistribution policy remains.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Remove Deviation for nativepreference
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* remove dev from metadata.textproto
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Fixed typo in deviation function
“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
* Add vendor changes
- Add createInterfaces() to ensure interfaces are created prior to assigning to VRF
- Remove setNoPeerGroup / conditional statement
- Enabled BGP global AFISAFI to BGP configs (REF: openconfig#2420)
- Added 3s sleep for Port2 test to ensure AFTs update
- Add 2 deviations SetRoutePrefNative, TableConnectionsUnsupported
- Changed BatchReplace to BatchUpdate to ensure route redistribution policy remains.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Remove Deviation for nativepreference
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* remove dev from metadata.textproto
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

* Fixed typo in deviation function
“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants