Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TE-16.2 Encap Frr Test - fix for using l2 rules and sequenceID #2889

Merged
merged 11 commits into from
May 27, 2024
Merged

TE-16.2 Encap Frr Test - fix for using l2 rules and sequenceID #2889

merged 11 commits into from
May 27, 2024

Conversation

suredhar
Copy link
Contributor

  1. Added back code to use deviation for default class by using L2 rules.
  2. Added a function to generate sequence IDs off a base value to avoid out-of-order rule sequences in a policy-map configuration.
  3. Added a deviation for the gRIBI IPv4 route. The device does not support a MAC address, only a next-hop entry.
  4. Added the following deviations:
    -> gribi_mac_override_with_static_arp
    -> interface_ref_interface_id_format
    -> pf_require_match_default_rule

@suredhar suredhar requested review from a team as code owners April 10, 2024 11:28
@OpenConfigBot
Copy link

OpenConfigBot commented Apr 10, 2024 •
edited
Loading

Pull Request Functional Test Report for #2889 / d751301

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 TE-16.2: encapsulation FRR scenarios
Cisco 8000E status
 TE-16.2: encapsulation FRR scenarios
Cisco XRd status
 TE-16.2: encapsulation FRR scenarios
Juniper ncPTX status
 TE-16.2: encapsulation FRR scenarios
Nokia SR Linux status
 TE-16.2: encapsulation FRR scenarios
Openconfig Lemming status
 TE-16.2: encapsulation FRR scenarios

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 TE-16.2: encapsulation FRR scenarios
Cisco 8808 status
 TE-16.2: encapsulation FRR scenarios
Juniper PTX10008 status
 TE-16.2: encapsulation FRR scenarios
Nokia 7250 IXR-10e status
 TE-16.2: encapsulation FRR scenarios

Help

@coveralls
Copy link

coveralls commented Apr 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9227587216

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9226667784: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

AmrNJ
AmrNJ requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@AmrNJ AmrNJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails at speed setting.

nsadhasivam
nsadhasivam previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

feature/gribi/otg_tests/encap_frr/encap_frr_test.go Outdated Show resolved Hide resolved
feature/gribi/otg_tests/encap_frr/encap_frr_test.go Outdated Show resolved Hide resolved
nsadhasivam
nsadhasivam approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nsadhasivam nsadhasivam merged commit 1c4ac7e into openconfig:main May 27, 2024
13 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request May 27, 2024
@suredhar @arvbaska1
@ram-mac @frasieroh
TE-16.2 Encap Frr Test - fix for using l2 rules and sequenceID (openc…
c421384 
…onfig#2889)

* Fixing TE 16.2

* added SeqId off set method

* change to skip port speed config

* update with changes for secondary IPv4

* add deviation in metadata

* remove unused func

* address comment for programAftWithDummyIP name

---------

Co-authored-by: arvbaska1 <[email protected]>
Co-authored-by: arvbaska1 <[email protected]>
Co-authored-by: Ram <[email protected]>
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Jul 10, 2024
@suredhar @arvbaska1
@ram-mac @ANISH-GOTTAPU
TE-16.2 Encap Frr Test - fix for using l2 rules and sequenceID (openc…
b872f34 
…onfig#2889)

* Fixing TE 16.2

* added SeqId off set method

* change to skip port speed config

* update with changes for secondary IPv4

* add deviation in metadata

* remove unused func

* address comment for programAftWithDummyIP name

---------

Co-authored-by: arvbaska1 <[email protected]>
Co-authored-by: arvbaska1 <[email protected]>
Co-authored-by: Ram <[email protected]>
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
@suredhar @arvbaska1
@ram-mac @bkreddy143
TE-16.2 Encap Frr Test - fix for using l2 rules and sequenceID (openc…
fcc8cca 
…onfig#2889)

* Fixing TE 16.2

* added SeqId off set method

* change to skip port speed config

* update with changes for secondary IPv4

* add deviation in metadata

* remove unused func

* address comment for programAftWithDummyIP name

---------

Co-authored-by: arvbaska1 <[email protected]>
Co-authored-by: arvbaska1 <[email protected]>
Co-authored-by: Ram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvbaska1 arvbaska1 arvbaska1 left review comments

@nsadhasivam nsadhasivam nsadhasivam approved these changes

@AmrNJ AmrNJ AmrNJ approved these changes

@michaelore michaelore Awaiting requested review from michaelore michaelore was automatically assigned from openconfig/featureprofiles-maintainers-otg

Assignees
No one assigned
Labels
cisco-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@suredhar @OpenConfigBot @coveralls @arvbaska1 @nsadhasivam @AmrNJ @ram-mac